Skip to content

Commit c0dd4c5

Browse files
committed
Refactor setup function to improve serial output and remove TODO comment regarding LEDC initialization
1 parent da93c9c commit c0dd4c5

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

keyboard/keyboard.ino

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,11 +32,10 @@ void setup()
3232
Wire.onRequest(onRequest);
3333
Wire.begin((uint8_t)I2C_DEV_ADDR, SDA, SCL, 100000UL);
3434
Serial.println("Starting keyboard work!");
35-
// TODO: Upstream this change to fix the error reported over serial by the keyboard: E (229) ledc: ledc_get_duty(740): LEDC is not initialized
3635
ledcSetup(KEYBOARD_BRIGHTNESS_CH, KEYBOARD_BRIGHTNESS_FREQ, KEYBOARD_BRIGHTNESS_RES);
3736
ledcAttachPin(KEYBOARD_BACKLIGHT_PIN, KEYBOARD_BRIGHTNESS_CH);
3837
ledcWrite(KEYBOARD_BRIGHTNESS_CH, KEYBOARD_BRIGHTNESS_DEFAULT);
39-
Serial.println("4");
38+
Serial.println("************************************");
4039
for (int x = 0; x < ROW_COUNT; x++) {
4140
Serial.print(rows[x]); Serial.println(" as input-pullup");
4241
pinMode(rows[x], INPUT);

0 commit comments

Comments
 (0)