Skip to content

Commit 0cbdde0

Browse files
committed
Fix load reviews
1 parent 98ba626 commit 0cbdde0

File tree

4 files changed

+11
-7
lines changed

4 files changed

+11
-7
lines changed

composer.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
"name": "scriptua/magento2-quickview",
33
"description": "Script QuickView Module",
44
"require": {
5-
"php": "~5.6.5|7.0.2|7.0.4|~7.0.6",
5+
"php": "~7.0.0|~7.1.0|~7.2.0",
66
"magento/module-catalog": "102.* |101.* | 100.*",
7-
"scriptua/magento2-base": "1.0.*"
7+
"scriptua/magento2-base": "1.1.*"
88
},
99
"type": "magento2-module",
10-
"version": "1.0.1",
10+
"version": "1.0.2",
1111
"license": "GNU-3.0",
1212
"autoload": {
1313
"files": [

etc/module.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
-->
77

88
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
9-
<module name="Script_QuickView" setup_version="1.0.1" >
9+
<module name="Script_QuickView" setup_version="1.0.2" >
1010
<sequence>
1111
<module name="Magento_Catalog"/>
1212
<module name="Script_Base"/>

view/frontend/layout/script_quickview_catalog_product_view.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,8 @@
130130
<block name="product.reviews" class="Magento\Framework\View\Element\Template" template="Script_QuickView::quickview.content.phtml" group="quickview_tabs" after="-">
131131
<arguments>
132132
<argument translate="true" name="title" xsi:type="string">Reviews</argument>
133-
<argument name="html_id" xsi:type="string">quickview-reviews</argument>
134-
<argument name="html_class" xsi:type="string">quickview-reviews</argument>
133+
<argument name="html_id" xsi:type="string">reviews</argument>
134+
<argument name="html_class" xsi:type="string">reviews</argument>
135135
</arguments>
136136
<referenceBlock name="require-cookie">
137137
<arguments>

view/frontend/templates/quickview.tabs.phtml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,11 @@ use Script\Base\Helpers\Html;
3737
$contentClass = $block->getChildData($alias, 'html_class');
3838
$label = $block->getChildData($alias, 'title');
3939
?>
40-
<div class="data item title qs-title" aria-labeledby="tab-label-<?php echo $contentId; ?>-title">
40+
<div class="data item title qs-title"
41+
aria-labeledby="tab-label-<?php echo $contentId; ?>-title"
42+
data-role="collapsible"
43+
id="tab-label-<?= /* @escapeNotVerified */ $contentId ?>"
44+
>
4145
<a class="data switch" tabindex="-1" data-role="trigger" href="#<?php echo $contentId; ?>" id="tab-label-<?php echo $contentId; ?>-title" data-toggle="switch">
4246
<?php echo $label; ?>
4347
</a>

0 commit comments

Comments
 (0)