Merge remote-tracking branch 'upstream/master'

* upstream/master:
  Added support for harper in markdown files (dense-analysis#5104)
  fix(phpcs): run from project root instead of file directory (dense-analysis#5105)
  support running solargraph via bundle (dense-analysis#5097)
  Fix dense-analysis#5062 - Keep ALE LSP compatible with Neovim 0.10 and 0.11+
  Tell OpenCode how to write ALE code
  feat(rstcheck): Add automatic --config support with version check (dense-analysis#5095)
  Truncate astro test files to quiet dependabot
  Skip ALE docker download attempts
  doc goimport (dense-analysis#5093)
  refactor: use ale#Pad for option padding across the codebase (dense-analysis#5091)
  add option to lint diff buffers (dense-analysis#3185)

Author: hsanson

AGENTS.md

@@ -0,0 +1,6 @@
+# ALE Agent instructions
+
+1. Read documentation from `doc/ale-development.txt` to understand how to be an
+   ALE developer.
+2. Run Vader/Vim tests with `./run-tests -q --fast test/path/some_file.vader`
+3. When editing Lua code run Lua tests with `./run-tests -q --lua-only`

ale_linters/cpp/clazy.vim

@@ -18,7 +18,7 @@ function! ale_linters#cpp#clazy#GetCommand(buffer) abort
     return '%e'
     \   . (!empty(l:checks) ? ' -checks=' . ale#Escape(l:checks) : '')
     \   . (!empty(l:build_dir) ? ' -p ' . ale#Escape(l:build_dir) : '')
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' %s'
 endfunction
 

ale_linters/cs/mcs.vim

@@ -4,7 +4,7 @@ function! ale_linters#cs#mcs#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'cs_mcs_options')
 
     return 'mcs -unsafe --parse'
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' %t'
 endfunction
 

ale_linters/go/revive.vim

@@ -8,7 +8,7 @@ function! ale_linters#go#revive#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'go_revive_options')
 
     return ale#go#EnvString(a:buffer) . '%e'
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' %t'
 endfunction
 

ale_linters/go/staticcheck.vim

@@ -13,11 +13,11 @@ function! ale_linters#go#staticcheck#GetCommand(buffer) abort
 
     if l:lint_package
         return l:env . '%e'
-        \   . (!empty(l:options) ? ' ' . l:options : '') . ' .'
+        \   . ale#Pad(l:options) . ' .'
     endif
 
     return l:env . '%e'
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' %s:t'
 endfunction
 

ale_linters/groovy/npmgroovylint.vim

@@ -8,7 +8,7 @@ function! ale_linters#groovy#npmgroovylint#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'groovy_npmgroovylint_options')
 
     return '%e --failon none --output json'
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' %t'
 endfunction
 

ale_linters/html/stylelint.vim

@@ -15,7 +15,7 @@ function! ale_linters#html#stylelint#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'html_stylelint_options')
 
     return ale#Escape(l:executable)
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' --no-color --stdin-filename %s'
 endfunction
 

ale_linters/javascript/standard.vim

@@ -19,7 +19,7 @@ function! ale_linters#javascript#standard#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'javascript_standard_options')
 
     return ale#node#Executable(a:buffer, l:executable)
-    \   . (!empty(l:options) ? ' ' . l:options : '')
+    \   . ale#Pad(l:options)
     \   . ' --stdin %s'
 endfunction
 

ale_linters/markdown/harper.vim

@@ -0,0 +1,32 @@
+" Author: Armand Halbert <armand.halbert@gmail.com>
+" Description: Harper for Markdown files
+
+call ale#Set('markdown_harper_config', {
+\   'harper-ls': {
+\       'diagnosticSeverity': 'hint',
+\       'dialect': 'American',
+\       'linters': {
+\           'SpellCheck': v:true,
+\           'SentenceCapitalization': v:true,
+\           'RepeatedWords': v:true,
+\           'LongSentences': v:true,
+\           'AnA': v:true,
+\           'Spaces': v:true,
+\           'SpelledNumbers': v:false,
+\           'WrongQuotes': v:false,
+\       },
+\   },
+\})
+
+call ale#linter#Define('markdown', {
+\   'name': 'harper',
+\   'lsp': 'stdio',
+\   'executable': 'harper-ls',
+\   'command': '%e --stdio',
+\   'project_root': function('ale_linters#markdown#harper#GetProjectRoot'),
+\   'lsp_config': {b -> ale#Var(b, 'markdown_harper_config')},
+\})
+
+function! ale_linters#markdown#harper#GetProjectRoot(buffer) abort
+    return fnamemodify(bufname(a:buffer), ':p:h')
+endfunction

ale_linters/markdown/markdownlint.vim

@@ -14,7 +14,7 @@ function! ale_linters#markdown#markdownlint#GetCommand(buffer) abort
     let l:options = ale#Var(a:buffer, 'markdown_markdownlint_options')
 
     return ale#Escape(l:executable)
-    \ . (!empty(l:options) ? ' ' . l:options : '') . ' %s'
+    \ . ale#Pad(l:options) . ' %s'
 endfunction
 
 call ale#linter#Define('markdown', {