Commit fe3c1dc
Fix the llm module e2e test (pytorch#15275)
The generate API for llm has two issues.
- The input image could be null, but prefillImages assume non-null, this
cause prefillImages return Error::EndOfMethod, this can be fixed by
adding a null check on the java layer
- The generate didn't pass prompt which caused stack overflow
Test plan
Run all e2e test on the local emulator and run via CI
Co-authored-by: Haiting Pu <[email protected]>1 parent 9b744b4 commit fe3c1dc
File tree
1 file changed
+4
-2
lines changed- extension/android/executorch_android/src/main/java/org/pytorch/executorch/extension/llm
1 file changed
+4
-2
lines changedLines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
182 | 182 | | |
183 | 183 | | |
184 | 184 | | |
185 | | - | |
186 | | - | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
187 | 189 | | |
188 | 190 | | |
189 | 191 | | |
| |||
0 commit comments