Skip to content

Commit d44d6e5

Browse files
committed
fix(docker): posix and shell entrypoint
1 parent 81f49a8 commit d44d6e5

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

Dockerfile.with-model

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@ COPY models /models
3030

3131
# Copy and set permissions on the entrypoint script BEFORE changing user
3232
COPY docker-entrypoint.sh /app/docker-entrypoint.sh
33-
RUN chmod +x /app/docker-entrypoint.sh
33+
# Ensure script has Unix line endings and is executable
34+
RUN sed -i 's/\r$//' /app/docker-entrypoint.sh && \
35+
chmod +x /app/docker-entrypoint.sh
3436

3537
ENV PYTHONPATH=/app
3638
ENV MODEL_PATH=/models

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,8 @@ docker-build-with-model: ## Build Docker image with embedded model (use IMAGE_NA
112112
fi; \
113113
fi
114114
@echo "Building Docker image..."
115-
@docker build -t $(IMAGE_NAME) -f Dockerfile.with-model .
116-
@echo "Docker image with $(MODEL_SIZE) model built successfully as $(IMAGE_NAME)"
115+
@docker build -t $(IMAGE_NAME):$(MODEL_SIZE) -f Dockerfile.with-model .
116+
@echo "Docker image with $(MODEL_SIZE) model built successfully as $(IMAGE_NAME):$(MODEL_SIZE)"
117117

118118
docker-run: ## Run Docker container with model volume mount
119119
@echo "Checking for model files..."

docker-entrypoint.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
1-
#!/bin/bash
1+
#!/bin/sh
22
set -e
33

44
# Default to 1 worker if not specified
55
WORKER_COUNT=${WORKER_COUNT:-1}
66

77
# Convert WORKER_COUNT to integer (handles string values from Kubernetes)
88
# Use regex to validate if WORKER_COUNT is a valid number
9-
if [[ "$WORKER_COUNT" =~ ^[0-9]+$ ]]; then
9+
if [ -n "$WORKER_COUNT" ] && [ "$WORKER_COUNT" -eq "$WORKER_COUNT" ] 2>/dev/null; then
1010
WORKER_COUNT_INT=$WORKER_COUNT
1111
else
1212
echo "Warning: WORKER_COUNT '$WORKER_COUNT' is not a valid number. Defaulting to 1."

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[project]
22
name = "babeltron"
3-
version = "0.3.6"
3+
version = "0.3.7"
44
dynamic = ["version"]
55
description = "A Python-based REST API that leverages single multilingual models like mBERT to provide efficient text translation services"
66
authors = [

0 commit comments

Comments
 (0)