Implement Updater for Deno JS Runtime, fixes latest YouTube downloading issues.

hstr0100 · hstr0100 · commit 2fb82f1ebafd · 2026-01-30T16:03:11.000-03:00
diff --git a/core/src/main/java/net/brlns/gdownloader/downloader/DownloadManager.java b/core/src/main/java/net/brlns/gdownloader/downloader/DownloadManager.java
@@ -39,15 +39,15 @@
 import net.brlns.gdownloader.downloader.structs.DownloadResult;
 import net.brlns.gdownloader.event.EventDispatcher;
 import net.brlns.gdownloader.event.IEvent;
+import net.brlns.gdownloader.filters.AbstractUrlFilter;
+import net.brlns.gdownloader.filters.GenericFilter;
+import net.brlns.gdownloader.filters.YoutubeFilter;
+import net.brlns.gdownloader.filters.YoutubePlaylistFilter;
 import net.brlns.gdownloader.persistence.PersistenceManager;
 import net.brlns.gdownloader.persistence.entity.CounterTypeEnum;
 import net.brlns.gdownloader.persistence.entity.QueueEntryEntity;
 import net.brlns.gdownloader.process.ProcessMonitor;
 import net.brlns.gdownloader.settings.enums.PlayListOptionEnum;
-import net.brlns.gdownloader.filters.AbstractUrlFilter;
-import net.brlns.gdownloader.filters.GenericFilter;
-import net.brlns.gdownloader.filters.YoutubeFilter;
-import net.brlns.gdownloader.filters.YoutubePlaylistFilter;
 import net.brlns.gdownloader.system.ShutdownRegistry.CloseBefore;
 import net.brlns.gdownloader.system.taskbar.ITaskbarManager.TaskbarState;
 import net.brlns.gdownloader.system.taskbar.TaskbarManager;
diff --git a/core/src/main/java/net/brlns/gdownloader/downloader/GalleryDlDownloader.java b/core/src/main/java/net/brlns/gdownloader/downloader/GalleryDlDownloader.java
@@ -36,9 +36,9 @@
 import net.brlns.gdownloader.downloader.enums.DownloaderIdEnum;
 import net.brlns.gdownloader.downloader.structs.DownloadResult;
 import net.brlns.gdownloader.downloader.structs.MediaInfo;
+import net.brlns.gdownloader.filters.AbstractUrlFilter;
 import net.brlns.gdownloader.persistence.PersistenceManager;
 import net.brlns.gdownloader.process.ProcessArguments;
-import net.brlns.gdownloader.filters.AbstractUrlFilter;
 import net.brlns.gdownloader.util.CancelHook;
 import net.brlns.gdownloader.util.DirectoryDeduplicator;
 import net.brlns.gdownloader.util.DirectoryUtils;
diff --git a/core/src/main/java/net/brlns/gdownloader/downloader/QueueEntry.java b/core/src/main/java/net/brlns/gdownloader/downloader/QueueEntry.java
@@ -50,10 +50,10 @@
 import net.brlns.gdownloader.GDownloader;
 import net.brlns.gdownloader.downloader.enums.*;
 import net.brlns.gdownloader.downloader.structs.MediaInfo;
-import net.brlns.gdownloader.persistence.entity.QueueEntryEntity;
-import net.brlns.gdownloader.settings.enums.*;
 import net.brlns.gdownloader.filters.AbstractUrlFilter;
 import net.brlns.gdownloader.filters.GenericFilter;
+import net.brlns.gdownloader.persistence.entity.QueueEntryEntity;
+import net.brlns.gdownloader.settings.enums.*;
 import net.brlns.gdownloader.ui.MediaCard;
 import net.brlns.gdownloader.ui.menu.*;
 import net.brlns.gdownloader.ui.message.Message;
diff --git a/core/src/main/java/net/brlns/gdownloader/downloader/SpotDLDownloader.java b/core/src/main/java/net/brlns/gdownloader/downloader/SpotDLDownloader.java
@@ -37,9 +37,9 @@
 import net.brlns.gdownloader.downloader.enums.DownloaderIdEnum;
 import net.brlns.gdownloader.downloader.structs.DownloadResult;
 import net.brlns.gdownloader.downloader.structs.MediaInfo;
+import net.brlns.gdownloader.filters.AbstractUrlFilter;
 import net.brlns.gdownloader.persistence.PersistenceManager;
 import net.brlns.gdownloader.process.ProcessArguments;
-import net.brlns.gdownloader.filters.AbstractUrlFilter;
 import net.brlns.gdownloader.util.CancelHook;
 import net.brlns.gdownloader.util.DirectoryUtils;
 import net.brlns.gdownloader.util.FileUtils;
diff --git a/core/src/main/java/net/brlns/gdownloader/downloader/YtDlpDownloader.java b/core/src/main/java/net/brlns/gdownloader/downloader/YtDlpDownloader.java
@@ -39,15 +39,15 @@
 import net.brlns.gdownloader.downloader.structs.DownloadResult;
 import net.brlns.gdownloader.downloader.structs.MediaInfo;
 import net.brlns.gdownloader.ffmpeg.enums.AudioBitrateEnum;
+import net.brlns.gdownloader.filters.AbstractUrlFilter;
 import net.brlns.gdownloader.persistence.PersistenceManager;
 import net.brlns.gdownloader.process.ProcessArguments;
 import net.brlns.gdownloader.settings.QualitySettings;
 import net.brlns.gdownloader.settings.enums.AudioContainerEnum;
+import net.brlns.gdownloader.settings.enums.DescriptionContainerEnum;
 import net.brlns.gdownloader.settings.enums.SubtitleContainerEnum;
 import net.brlns.gdownloader.settings.enums.ThumbnailContainerEnum;
 import net.brlns.gdownloader.settings.enums.VideoContainerEnum;
-import net.brlns.gdownloader.settings.enums.DescriptionContainerEnum;
-import net.brlns.gdownloader.filters.AbstractUrlFilter;
 import net.brlns.gdownloader.util.CancelHook;
 import net.brlns.gdownloader.util.DirectoryUtils;
 import net.brlns.gdownloader.util.FileUtils;
@@ -68,6 +68,10 @@ public class YtDlpDownloader extends AbstractDownloader {
     @Setter
     private Optional<File> executablePath = Optional.empty();
 
+    @Getter
+    @Setter
+    private Optional<File> denoPath = Optional.empty();
+
     public YtDlpDownloader(DownloadManager managerIn) {
         super(managerIn);
     }
diff --git a/core/src/main/java/net/brlns/gdownloader/filters/GenericFilter.java b/core/src/main/java/net/brlns/gdownloader/filters/GenericFilter.java
@@ -19,12 +19,14 @@
 import com.fasterxml.jackson.annotation.JsonIgnore;
 import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
 import java.io.File;
+import java.util.Optional;
 import lombok.Data;
 import lombok.EqualsAndHashCode;
 import lombok.extern.slf4j.Slf4j;
 import net.brlns.gdownloader.GDownloader;
 import net.brlns.gdownloader.downloader.AbstractDownloader;
 import net.brlns.gdownloader.downloader.DownloadManager;
+import net.brlns.gdownloader.downloader.YtDlpDownloader;
 import net.brlns.gdownloader.downloader.enums.DownloadTypeEnum;
 import net.brlns.gdownloader.ffmpeg.enums.AudioBitrateEnum;
 import net.brlns.gdownloader.process.ProcessArguments;
@@ -91,6 +93,16 @@ protected ProcessArguments buildArguments(AbstractDownloader downloader, Downloa
                     );
                 }
 
+                if (downloader instanceof YtDlpDownloader ytDlpDownloader) {
+                    Optional<File> denoPath = ytDlpDownloader.getDenoPath();
+                    if (denoPath.isPresent()) {
+                        arguments.add(
+                            "--js-runtimes",
+                            "deno:" + denoPath.get().getAbsolutePath()
+                        );
+                    }
+                }
+
                 switch (typeEnum) {
                     case ALL -> {
                         if (config.isEnableExtraArguments()) {
diff --git a/core/src/main/java/net/brlns/gdownloader/persistence/entity/QueueEntryEntity.java b/core/src/main/java/net/brlns/gdownloader/persistence/entity/QueueEntryEntity.java
@@ -16,14 +16,14 @@
  */
 package net.brlns.gdownloader.persistence.entity;
 
-import net.brlns.gdownloader.filters.AbstractUrlFilter;
 import jakarta.persistence.*;
 import java.io.Serializable;
 import java.util.ArrayList;
 import lombok.AllArgsConstructor;
 import lombok.Data;
 import lombok.NoArgsConstructor;
 import net.brlns.gdownloader.downloader.enums.*;
+import net.brlns.gdownloader.filters.AbstractUrlFilter;
 import net.brlns.gdownloader.persistence.converter.*;
 
 /**
diff --git a/core/src/main/java/net/brlns/gdownloader/settings/Settings.java b/core/src/main/java/net/brlns/gdownloader/settings/Settings.java
@@ -29,13 +29,13 @@
 import net.brlns.gdownloader.GDownloader;
 import net.brlns.gdownloader.ffmpeg.enums.AudioCodecEnum;
 import net.brlns.gdownloader.ffmpeg.structs.FFmpegConfig;
+import net.brlns.gdownloader.filters.AbstractUrlFilter;
+import net.brlns.gdownloader.filters.GenericFilter;
 import net.brlns.gdownloader.settings.enums.BrowserEnum;
 import net.brlns.gdownloader.settings.enums.LanguageEnum;
 import net.brlns.gdownloader.settings.enums.PlayListOptionEnum;
 import net.brlns.gdownloader.settings.enums.ThemeEnum;
 import net.brlns.gdownloader.settings.enums.WebFilterEnum;
-import net.brlns.gdownloader.filters.AbstractUrlFilter;
-import net.brlns.gdownloader.filters.GenericFilter;
 
 /**
  * @author Gabriel / hstr0100 / vertx010
diff --git a/core/src/main/java/net/brlns/gdownloader/settings/enums/WebFilterEnum.java b/core/src/main/java/net/brlns/gdownloader/settings/enums/WebFilterEnum.java
@@ -16,16 +16,16 @@
  */
 package net.brlns.gdownloader.settings.enums;
 
-import net.brlns.gdownloader.filters.YoutubeFilter;
+import lombok.Getter;
 import net.brlns.gdownloader.filters.CrunchyrollFilter;
-import net.brlns.gdownloader.filters.XFilter;
-import net.brlns.gdownloader.filters.YoutubePlaylistFilter;
+import net.brlns.gdownloader.filters.DropoutFilter;
+import net.brlns.gdownloader.filters.FacebookFilter;
+import net.brlns.gdownloader.filters.GenericFilter;
 import net.brlns.gdownloader.filters.RedditFilter;
 import net.brlns.gdownloader.filters.TwitchFilter;
-import net.brlns.gdownloader.filters.GenericFilter;
-import net.brlns.gdownloader.filters.FacebookFilter;
-import net.brlns.gdownloader.filters.DropoutFilter;
-import lombok.Getter;
+import net.brlns.gdownloader.filters.XFilter;
+import net.brlns.gdownloader.filters.YoutubeFilter;
+import net.brlns.gdownloader.filters.YoutubePlaylistFilter;
 
 /**
  * The sole purpose of this enum as of 2024-10-20 is for config migration.
diff --git a/core/src/main/java/net/brlns/gdownloader/ui/SettingsPanel.java b/core/src/main/java/net/brlns/gdownloader/ui/SettingsPanel.java
@@ -41,11 +41,11 @@
 import net.brlns.gdownloader.GDownloader;
 import net.brlns.gdownloader.ffmpeg.enums.AudioBitrateEnum;
 import net.brlns.gdownloader.ffmpeg.structs.FFmpegConfig;
+import net.brlns.gdownloader.filters.AbstractUrlFilter;
 import net.brlns.gdownloader.lang.ITranslatable;
 import net.brlns.gdownloader.settings.QualitySettings;
 import net.brlns.gdownloader.settings.Settings;
 import net.brlns.gdownloader.settings.enums.*;
-import net.brlns.gdownloader.filters.AbstractUrlFilter;
 import net.brlns.gdownloader.system.StartupManager;
 import net.brlns.gdownloader.ui.builder.CheckBoxBuilder;
 import net.brlns.gdownloader.ui.builder.ComboBoxBuilder;
diff --git a/core/src/main/java/net/brlns/gdownloader/updater/ArchVersionEnum.java b/core/src/main/java/net/brlns/gdownloader/updater/ArchVersionEnum.java
@@ -38,11 +38,13 @@ public enum ArchVersionEnum {
         .build()),
     MAC_X64(UpdateDefinitions.builder()
         .ytDlpBinary("yt-dlp_macos")
+        .denoBinary("deno-x86_64-apple-darwin.zip")
         .spotDlBinary("-darwin")
         .os(OS.MAC)
         .build()),
     MAC_ARM64(UpdateDefinitions.builder()
         .ytDlpBinary("yt-dlp_macos")
+        .denoBinary("deno-aarch64-apple-darwin.zip")
         .spotDlBinary("-darwin")
         .os(OS.MAC)
         .build()),
@@ -54,6 +56,7 @@ public enum ArchVersionEnum {
     // TODO: https://aka.ms/vs/17/release/vc_redist.x86.exe
     WINDOWS_X64(UpdateDefinitions.builder()
         .ytDlpBinary("yt-dlp.exe")
+        .denoBinary("deno-x86_64-pc-windows-msvc.zip")
         .galleryDlBinary("gallery-dl.exe")
         .spotDlBinary("-win32.exe")
         // Neither Apache Compress nor any java library that I know of supports the -mx=9 option used by FFmpeg's 7zs
@@ -65,6 +68,7 @@ public enum ArchVersionEnum {
     // TODO: Linux ffmpeg setup
     LINUX_X64(UpdateDefinitions.builder()
         .ytDlpBinary("yt-dlp_linux")
+        .denoBinary("deno-x86_64-unknown-linux-gnu.zip")
         .galleryDlBinary("gallery-dl.bin")
         .spotDlBinary("-linux")
         .selfBinary("linux_portable_amd64.zip")
@@ -77,6 +81,7 @@ public enum ArchVersionEnum {
         .build()),
     LINUX_ARM64(UpdateDefinitions.builder()
         .ytDlpBinary("yt-dlp_linux_aarch64")
+        .denoBinary("deno-aarch64-unknown-linux-gnu.zip")
         // As of 2025-04-26, updates for other architectures are only supported by AppImage
         //.selfBinary("linux_portable_arm64.zip")
         .selfAppImageBinary("aarch64.AppImage")
@@ -180,6 +185,8 @@ private static boolean isMacOsOlderThanBigSur() {
     public static class UpdateDefinitions {
 
         private final String ytDlpBinary;
+        // New huge absurd dependency required for dealing with YouTube shenanigans.
+        private final String denoBinary;
         private final String galleryDlBinary;
         private final String spotDlBinary;
         private final String ffmpegBinary;
diff --git a/core/src/main/java/net/brlns/gdownloader/updater/UpdateManager.java b/core/src/main/java/net/brlns/gdownloader/updater/UpdateManager.java
@@ -60,6 +60,7 @@ private void init() {
         registerUpdater(new SelfJarUpdater(main));
 
         registerUpdater(new YtDlpUpdater(main));
+        registerUpdater(new DenoUpdater(main));
         registerUpdater(new GalleryDlUpdater(main));
         registerUpdater(new SpotDLUpdater(main));
         registerUpdater(new FFMpegUpdater(main));
diff --git a/core/src/main/java/net/brlns/gdownloader/updater/git/DenoUpdater.java b/core/src/main/java/net/brlns/gdownloader/updater/git/DenoUpdater.java
diff --git a/core/src/main/java/net/brlns/gdownloader/updater/git/FFMpegUpdater.java b/core/src/main/java/net/brlns/gdownloader/updater/git/FFMpegUpdater.java
diff --git a/core/src/test/java/net/brlns/gdownloader/UrlFilterTest.java b/core/src/test/java/net/brlns/gdownloader/UrlFilterTest.java
