mock: enable more tests (#201)

Author: alissa-tung

client/src/test/java/io/hstream/RecordUtilsTest.java

@@ -33,7 +33,7 @@ public void compressRecordsWithZstd() {
     testCompressRecords(CompressionType.ZSTD);
   }
 
-  @Disabled
+  @Disabled("compressRatio")
   @Test
   public void compressRatioWithGzip() {
     compressRatio(4096, 100, CompressionType.GZIP);
@@ -43,7 +43,7 @@ public void compressRatioWithGzip() {
     compressRatio(4096, 1000, CompressionType.GZIP);
   }
 
-  @Disabled
+  @Disabled("compressRatio")
   @Test
   public void compressRatioWithZstd() {
     compressRatio(4096, 100, CompressionType.ZSTD);

client/src/test/java/io/hstream/impl/ProducerBuilderImplTest.java

@@ -1,38 +1,37 @@
 package io.hstream.impl;
 
+import static io.hstream.HServerMockKt.buildMockedClient;
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
-import static org.mockito.Mockito.mock;
 
+import io.hstream.HStreamClient;
 import io.hstream.Producer;
-import org.junit.jupiter.api.Disabled;
 import org.junit.jupiter.api.Test;
 import org.junit.runner.RunWith;
 import org.mockito.junit.MockitoJUnitRunner;
 
 @RunWith(MockitoJUnitRunner.class)
-@Disabled("mock init")
 public class ProducerBuilderImplTest {
 
   @Test
   public void testBuildWithValidInput() {
-    HStreamClientKtImpl client = mock(HStreamClientKtImpl.class);
-    ProducerBuilderImpl builder = new ProducerBuilderImpl(client);
+    HStreamClient client = buildMockedClient();
+    ProducerBuilderImpl builder = new ProducerBuilderImpl((HStreamClientKtImpl) client);
     Producer producer = builder.stream("test-stream").requestTimeoutMs(1000).build();
     assertNotNull(producer);
   }
 
   @Test
   public void testBuildWithMissingStreamName() {
-    HStreamClientKtImpl client = mock(HStreamClientKtImpl.class);
-    ProducerBuilderImpl builder = new ProducerBuilderImpl(client);
-    assertThrows(NullPointerException.class, () -> builder.requestTimeoutMs(1000).build());
+    HStreamClient client = buildMockedClient();
+    ProducerBuilderImpl builder = new ProducerBuilderImpl((HStreamClientKtImpl) client);
+    assertThrows(IllegalArgumentException.class, () -> builder.requestTimeoutMs(1000).build());
   }
 
   @Test
   public void testBuildWithInvalidRequestTimeoutMs() {
-    HStreamClientKtImpl client = mock(HStreamClientKtImpl.class);
-    ProducerBuilderImpl builder = new ProducerBuilderImpl(client);
+    HStreamClient client = buildMockedClient();
+    ProducerBuilderImpl builder = new ProducerBuilderImpl((HStreamClientKtImpl) client);
     assertThrows(
         IllegalArgumentException.class,
         () -> {
@@ -50,16 +49,16 @@ public void testBuildWithNullClient() {
 
   @Test
   public void testBuildWithDefaultRequestTimeoutMs() {
-    HStreamClientKtImpl client = mock(HStreamClientKtImpl.class);
-    ProducerBuilderImpl builder = new ProducerBuilderImpl(client);
+    HStreamClient client = buildMockedClient();
+    ProducerBuilderImpl builder = new ProducerBuilderImpl((HStreamClientKtImpl) client);
     Producer producer = builder.stream("test-stream").build();
     assertNotNull(producer);
   }
 
   @Test
   public void testBuildWithMaxRequestTimeoutMs() {
-    HStreamClientKtImpl client = mock(HStreamClientKtImpl.class);
-    ProducerBuilderImpl builder = new ProducerBuilderImpl(client);
+    HStreamClient client = buildMockedClient();
+    ProducerBuilderImpl builder = new ProducerBuilderImpl((HStreamClientKtImpl) client);
     Producer producer = builder.stream("test-stream").requestTimeoutMs(Long.MAX_VALUE).build();
     assertNotNull(producer);
   }

client/src/test/kotlin/io/hstream/HServerMock.kt

@@ -15,13 +15,16 @@ import io.hstream.impl.unaryCallWithCurrentUrls
 import io.hstream.internal.DeleteStreamRequest
 import io.hstream.internal.DescribeClusterResponse
 import io.hstream.internal.HStreamApiGrpc
+import io.hstream.internal.ListShardsRequest
+import io.hstream.internal.ListShardsResponse
 import io.hstream.internal.ListStreamsRequest
 import io.hstream.internal.ListStreamsResponse
 import io.hstream.internal.LookupResourceRequest
 import io.hstream.internal.LookupSubscriptionRequest
 import io.hstream.internal.LookupSubscriptionResponse
 import io.hstream.internal.ResourceType
 import io.hstream.internal.ServerNode
+import io.hstream.internal.Shard
 import io.hstream.internal.SpecialOffset
 import io.hstream.internal.StreamingFetchRequest
 import io.hstream.internal.StreamingFetchResponse
@@ -258,6 +261,22 @@ open class HServerMock(
             }
         }
     }
+
+    override fun listShards(request: ListShardsRequest?, responseObserver: StreamObserver<ListShardsResponse>?) {
+        val streamName = request!!.streamName
+
+        responseObserver!!.onNext(
+            ListShardsResponse.newBuilder()
+                .addShards(
+                    Shard.newBuilder()
+                        .setStreamName(streamName)
+                        // TODO: add more fields
+                        .build()
+                )
+                .build()
+        )
+        responseObserver.onCompleted()
+    }
 }
 
 fun mockServiceImpl(hMetaMockCluster: HMetaMock, serverName: String, hServerMockImpl: Class<out HStreamApiGrpc.HStreamApiImplBase>): HStreamApiGrpc.HStreamApiImplBase {

client/src/test/kotlin/io/hstream/impl/BufferedProducerBuilderImplTest.kt

@@ -0,0 +1,58 @@
+package io.hstream.impl
+
+import io.hstream.HStreamDBClientException
+import io.hstream.buildMockedClient
+import org.junit.jupiter.api.Assertions.assertNotNull
+import org.junit.jupiter.api.Assertions.assertThrows
+import org.junit.jupiter.api.Test
+
+class BufferedProducerBuilderImplTest {
+
+    @Test
+    fun testBuildWithValidInput() {
+        val client = buildMockedClient()
+        val builder = BufferedProducerBuilderImpl(client as HStreamClientKtImpl)
+        val producer = builder.stream("test-stream").requestTimeoutMs(1000).build()
+        assertNotNull(producer)
+    }
+
+    @Test
+    fun testBuildWithMissingStreamName() {
+        val client = buildMockedClient()
+        val builder = BufferedProducerBuilderImpl(client as HStreamClientKtImpl)
+        assertThrows(HStreamDBClientException::class.java) { builder.requestTimeoutMs(1000).build() }
+    }
+
+    @Test
+    fun testBuildWithInvalidRequestTimeoutMs() {
+        val client = buildMockedClient()
+        val builder = BufferedProducerBuilderImpl(client as HStreamClientKtImpl)
+        assertThrows(
+            IllegalArgumentException::class.java
+        ) { builder.stream("test-stream").requestTimeoutMs(-1).build() }
+    }
+
+    @Test
+    fun testBuildWithNullClient() {
+        val builder = BufferedProducerBuilderImpl(null)
+        assertThrows(
+            NullPointerException::class.java
+        ) { builder.stream("test-stream").requestTimeoutMs(1000).build() }
+    }
+
+    @Test
+    fun testBuildWithDefaultRequestTimeoutMs() {
+        val client = buildMockedClient()
+        val builder = BufferedProducerBuilderImpl(client as HStreamClientKtImpl)
+        val producer = builder.stream("test-stream").build()
+        assertNotNull(producer)
+    }
+
+    @Test
+    fun testBuildWithMaxRequestTimeoutMs() {
+        val client = buildMockedClient()
+        val builder = BufferedProducerBuilderImpl(client as HStreamClientKtImpl)
+        val producer = builder.stream("test-stream").requestTimeoutMs(Long.MAX_VALUE).build()
+        assertNotNull(producer)
+    }
+}