Skip to content

Commit 48949df

Browse files
authored
refactor orderingKey (#130)
1 parent 388a637 commit 48949df

File tree

6 files changed

+33
-33
lines changed

6 files changed

+33
-33
lines changed

client/src/main/java/io/hstream/BufferedProducerBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ public interface BufferedProducerBuilder {
66
BufferedProducerBuilder stream(String streamName);
77

88
/**
9-
* BufferedProducer will buffer records for each ordering key as a batch to send to servers, so
10-
* {@link BatchSetting} is to control the batch buffer.
9+
* BufferedProducer will buffer records for each shard as a batch to send to servers, so {@link
10+
* BatchSetting} is to control the batch buffer.
1111
*
1212
* @param batchSetting setting for batch buffer
1313
* @return the BufferedProducerBuilder instance

client/src/main/java/io/hstream/Record.java

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
public class Record {
66

7-
private String orderingKey;
7+
private String partitionKey;
88
private byte[] rawRecord;
99
private HRecord hRecord;
1010
private boolean isRawRecord;
@@ -13,24 +13,24 @@ public static Builder newBuilder() {
1313
return new Builder();
1414
}
1515

16-
private Record(String orderingKey, byte[] rawRecord) {
16+
private Record(String partitionKey, byte[] rawRecord) {
1717
isRawRecord = true;
18-
this.orderingKey = orderingKey;
18+
this.partitionKey = partitionKey;
1919
this.rawRecord = rawRecord;
2020
}
2121

22-
private Record(String orderingKey, HRecord hRecord) {
22+
private Record(String partitionKey, HRecord hRecord) {
2323
isRawRecord = false;
24-
this.orderingKey = orderingKey;
24+
this.partitionKey = partitionKey;
2525
this.hRecord = hRecord;
2626
}
2727

28-
public String getOrderingKey() {
29-
return orderingKey;
28+
public String getPartitionKey() {
29+
return partitionKey;
3030
}
3131

32-
public void setOrderingKey(String orderingKey) {
33-
this.orderingKey = orderingKey;
32+
public void setPartitionKey(String partitionKey) {
33+
this.partitionKey = partitionKey;
3434
}
3535

3636
public byte[] getRawRecord() {
@@ -48,12 +48,12 @@ public boolean isRawRecord() {
4848
}
4949

5050
public static class Builder {
51-
private String orderingKey;
51+
private String partitionKey;
5252
private byte[] rawRecord;
5353
private HRecord hRecord;
5454

55-
public Builder orderingKey(String key) {
56-
this.orderingKey = key;
55+
public Builder partitionKey(String partitionKey) {
56+
this.partitionKey = partitionKey;
5757
return this;
5858
}
5959

@@ -71,9 +71,9 @@ public Record build() {
7171
checkArgument(
7272
(rawRecord != null && hRecord == null) || (rawRecord == null && hRecord != null));
7373
if (rawRecord != null) {
74-
return new Record(orderingKey, rawRecord);
74+
return new Record(partitionKey, rawRecord);
7575
} else {
76-
return new Record(orderingKey, hRecord);
76+
return new Record(partitionKey, hRecord);
7777
}
7878
}
7979
}

client/src/main/java/io/hstream/RecordHeader.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
package io.hstream;
22

33
public class RecordHeader {
4-
private String orderingKey;
4+
private String partitionKey;
55

66
private RecordHeader(Builder builder) {
7-
this.orderingKey = builder.orderingKey;
7+
this.partitionKey = builder.partitionKey;
88
}
99

10-
public String getOrderingKey() {
11-
return orderingKey;
10+
public String getPartitionKey() {
11+
return partitionKey;
1212
}
1313

14-
public void setOrderingKey(String orderingKey) {
15-
this.orderingKey = orderingKey;
14+
public void setPartitionKey(String partitionKey) {
15+
this.partitionKey = partitionKey;
1616
}
1717

1818
public static Builder newBuild() {
@@ -21,10 +21,10 @@ public static Builder newBuild() {
2121

2222
public static class Builder {
2323

24-
private String orderingKey;
24+
private String partitionKey;
2525

26-
public Builder orderingKey(String orderingKey) {
27-
this.orderingKey = orderingKey;
26+
public Builder partitionKey(String partitionKey) {
27+
this.partitionKey = partitionKey;
2828
return Builder.this;
2929
}
3030

client/src/main/java/io/hstream/impl/DefaultSettings.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@ public class DefaultSettings {
66

77
public static final int APPEND_RETRY_MAX_TIMES = 5;
88

9-
public static final String DEFAULT_ORDERING_KEY = "";
9+
public static final String DEFAULT_PARTITION_KEY = "";
1010
}

client/src/main/java/io/hstream/util/RecordUtils.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public static HStreamRecord buildHStreamRecordFromRawRecord(byte[] rawRecord) {
2020
HStreamRecordHeader header =
2121
HStreamRecordHeader.newBuilder()
2222
.setFlag(HStreamRecordHeader.Flag.RAW)
23-
.setKey(DefaultSettings.DEFAULT_ORDERING_KEY)
23+
.setKey(DefaultSettings.DEFAULT_PARTITION_KEY)
2424
.build();
2525
return HStreamRecord.newBuilder()
2626
.setHeader(header)
@@ -32,7 +32,7 @@ public static HStreamRecord buildHStreamRecordFromHRecord(HRecord hRecord) {
3232
HStreamRecordHeader header =
3333
HStreamRecordHeader.newBuilder()
3434
.setFlag(HStreamRecordHeader.Flag.JSON)
35-
.setKey(DefaultSettings.DEFAULT_ORDERING_KEY)
35+
.setKey(DefaultSettings.DEFAULT_PARTITION_KEY)
3636
.build();
3737

3838
return HStreamRecord.newBuilder().setHeader(header).setPayload(hRecord.toByteString()).build();
@@ -43,12 +43,12 @@ public static HStreamRecord buildHStreamRecordFromRecord(Record record) {
4343
record.isRawRecord()
4444
? buildHStreamRecordFromRawRecord(record.getRawRecord())
4545
: buildHStreamRecordFromHRecord(record.getHRecord());
46-
if (record.getOrderingKey() == null) {
46+
if (record.getPartitionKey() == null) {
4747
return hStreamRecord;
4848
}
4949
HStreamRecordHeader newHeader =
5050
HStreamRecordHeader.newBuilder(hStreamRecord.getHeader())
51-
.setKey(record.getOrderingKey())
51+
.setKey(record.getPartitionKey())
5252
.build();
5353
return HStreamRecord.newBuilder(hStreamRecord).setHeader(newHeader).build();
5454
}
@@ -62,7 +62,7 @@ public static byte[] parseRawRecordFromHStreamRecord(HStreamRecord hStreamRecord
6262
}
6363

6464
public static RecordHeader parseRecordHeaderFromHStreamRecord(HStreamRecord hStreamRecord) {
65-
return RecordHeader.newBuild().orderingKey(hStreamRecord.getHeader().getKey()).build();
65+
return RecordHeader.newBuild().partitionKey(hStreamRecord.getHeader().getKey()).build();
6666
}
6767

6868
public static HRecord parseHRecordFromHStreamRecord(HStreamRecord hStreamRecord) {

client/src/main/kotlin/io/hstream/impl/ReaderKtImpl.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,10 @@ class ReaderKtImpl(
5656
val header = RecordUtils.parseRecordHeaderFromHStreamRecord(hStreamRecord)
5757
if (RecordUtils.isRawRecord(hStreamRecord)) {
5858
val rawRecord = RecordUtils.parseRawRecordFromHStreamRecord(hStreamRecord)
59-
Record.newBuilder().rawRecord(rawRecord).orderingKey(header.orderingKey).build()
59+
Record.newBuilder().rawRecord(rawRecord).partitionKey(header.partitionKey).build()
6060
} else {
6161
val hRecord = RecordUtils.parseHRecordFromHStreamRecord(hStreamRecord)
62-
Record.newBuilder().hRecord(hRecord).orderingKey(header.orderingKey).build()
62+
Record.newBuilder().hRecord(hRecord).partitionKey(header.partitionKey).build()
6363
}
6464
}
6565
readFuture.complete(res as MutableList<Record>?)

0 commit comments

Comments
 (0)