Fix bug #1378 and create a regression test.

threeifbyair · threeifbyair · commit 29cbf7f84eb7 · 2025-03-25T22:16:36.000-04:00
diff --git a/regression-tests/pure2-bugfix-bad-using.cpp2 b/regression-tests/pure2-bugfix-bad-using.cpp2
@@ -0,0 +1,3 @@
+main: () = {
+  using
+}
diff --git a/regression-tests/test-results/pure2-bugfix-bad-using.cpp2.output b/regression-tests/test-results/pure2-bugfix-bad-using.cpp2.output
@@ -0,0 +1,3 @@
+pure2-bugfix-bad-using.cpp2...
+pure2-bugfix-bad-using.cpp2(3,1): error: expected valid id-expression after 'using' (at '}')
+
diff --git a/source/parse.h b/source/parse.h
@@ -2275,8 +2275,7 @@ struct using_statement_node
     auto for_namespace() const
         -> bool
     {
-        assert(id);
-        return id->to_string().ends_with("::_");
+        return (id && id->to_string().ends_with("::_"));
     }
 
     auto position() const

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+pure2-bugfix-bad-using.cpp2...`
	`2`	`+pure2-bugfix-bad-using.cpp2(3,1): error: expected valid id-expression after 'using' (at '}')`
	`3`	`+`
Original file line number	Diff line number	Diff line change
`@@ -2275,8 +2275,7 @@ struct using_statement_node`
`2275`	`2275`	`auto for_namespace() const`
`2276`	`2276`	`-> bool`
`2277`	`2277`	`{`
`2278`		`- assert(id);`
`2279`		`- return id->to_string().ends_with("::_");`
	`2278`	`+ return (id && id->to_string().ends_with("::_"));`
`2280`	`2279`	`}`
`2281`	`2280`
`2282`	`2281`	`auto position() const`