Update system stats processing logic with also supporting legacy method https://github.com/MHSanaei/3x-ui/blob/40b6d7707a8d7856eb97e00ea7c86052859ce162/web/controller/server.go#L41

Author: hteppl

.github/workflows/dockerhub-publish.yaml

@@ -27,7 +27,7 @@ jobs:
           platforms: linux/amd64,linux/arm64
           push: true
           build-args: |
-            GIT_TAG=v1.3.2
+            GIT_TAG=v1.4.0
           tags: |
             hteppl/x-ui-exporter:latest
-            hteppl/x-ui-exporter:v1.3.2
+            hteppl/x-ui-exporter:v1.4.0

api/api.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"crypto/tls"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"io"
 	"net/http"
@@ -176,9 +177,25 @@ func (a *APIClient) FetchServerStatus(cookie *http.Cookie) error {
 	// Clear old version metric to avoid accumulating obsolete label values
 	metrics.XrayVersion.Reset()
 
-	body, err := a.sendRequest("/server/status", http.MethodPost, cookie)
+	var (
+		body []byte
+		err  error
+	)
+
+	// Try GET first
+	body, err = a.sendRequest("/server/status", http.MethodGet, cookie)
 	if err != nil {
-		return fmt.Errorf("system stats: %w", err)
+		// Check if error is due to HTTP method not allowed or endpoint not found
+		var httpErr *HTTPError
+		if errors.As(err, &httpErr) && (httpErr.StatusCode == http.StatusMethodNotAllowed || httpErr.StatusCode == http.StatusNotFound) {
+			// Retry with POST
+			body, err = a.sendRequest("/server/status", http.MethodPost, cookie)
+			if err != nil {
+				return fmt.Errorf("system stats (POST fallback): %w", err)
+			}
+		} else {
+			return fmt.Errorf("system stats (GET): %w", err)
+		}
 	}
 
 	response := serverStatusPool.Get().(*client3xui.ServerStatusResponse)
@@ -289,6 +306,15 @@ func (a *APIClient) createRequest(method, path string, cookie *http.Cookie) (*ht
 	return req, nil
 }
 
+type HTTPError struct {
+	StatusCode int
+	Body       []byte
+}
+
+func (e *HTTPError) Error() string {
+	return fmt.Sprintf("HTTP request failed with status %d", e.StatusCode)
+}
+
 func (a *APIClient) sendRequest(path, method string, cookie *http.Cookie) ([]byte, error) {
 	req, err := a.createRequest(method, path, cookie)
 	if err != nil {
@@ -303,5 +329,17 @@ func (a *APIClient) sendRequest(path, method string, cookie *http.Cookie) ([]byt
 		_ = resp.Body.Close()
 	}()
 
-	return io.ReadAll(resp.Body)
+	body, err := io.ReadAll(resp.Body)
+	if err != nil {
+		return nil, err
+	}
+
+	if resp.StatusCode < 200 || resp.StatusCode >= 300 {
+		return nil, &HTTPError{
+			StatusCode: resp.StatusCode,
+			Body:       body,
+		}
+	}
+
+	return body, nil
 }