WIP trying to fix linked regions in TMRegion

but not successful yet

Author: breznak

bindings/py/tests/regions/network_test.py

@@ -302,6 +302,8 @@ def testBuiltInRegions(self):
 
     tm_output = tm.getOutputArray("predictedActiveCells")
     sdr = tm_output.getSDR()
+    print(sdr.sparse)
+    print(EXPECTED_RESULT3)
     self.assertTrue(np.array_equal(sdr.sparse, EXPECTED_RESULT3))
 
   def testExecuteCommand1(self):

src/htm/regions/TMRegion.cpp

@@ -176,6 +176,16 @@ void TMRegion::initialize() {
   args_.sequencePos = 0;
 }
 
+
+bool TMRegion::isConnected_(string name) const {
+  const auto in = getInput(name);
+  const auto out = getOutput(name);
+  const bool hasOutput = (out != nullptr) and out->hasOutgoingLinks();
+  const bool hasInput  = (in  != nullptr) and in->hasIncomingLinks();
+  return hasInput or hasOutput;
+}
+
+
 void TMRegion::compute() {
 
   NTA_ASSERT(tm_) << "TM not initialized";
@@ -230,9 +240,11 @@ void TMRegion::compute() {
   //
   std::shared_ptr<Output> out;
   out = getOutput("bottomUpOut");
-  //set NTA_LOG_LEVEL = htm::LogLevel::LogLevel_Verbose
+  //set 
+  NTA_LOG_LEVEL = htm::LogLevel::LogLevel_Verbose;
+  NTA_CHECK(NTA_LOG_LEVEL == LogLevel::LogLevel_Verbose) << "setting Verbose failed, man";
   //to output the NTA_DEBUG statements below
-  if (out && out->hasOutgoingLinks() ) {
+  if (isConnected_("bottomUpOut") ) {
     SDR& sdr = out->getData().getSDR();
     tm_->getActiveCells(sdr); //active cells
     if (args_.orColumnOutputs) { //output as columns
@@ -241,24 +253,24 @@ void TMRegion::compute() {
     NTA_DEBUG << "bottomUpOut " << *out << std::endl;
   }
   out = getOutput("activeCells");
-  if (out && out->hasOutgoingLinks() ) {
+  if (isConnected_("activeCells")) {
     tm_->getActiveCells(out->getData().getSDR());
     NTA_DEBUG << "active " << *out << std::endl;
   }
   out = getOutput("predictedActiveCells");
-  if (out && out->hasOutgoingLinks() ) {
+  if (isConnected_("predictedActiveCells") ) {
     tm_->activateDendrites();
     tm_->getWinnerCells(out->getData().getSDR());
     NTA_DEBUG << "winners " << *out << std::endl;
   }
   out = getOutput("anomaly");
-  if (out && out->hasOutgoingLinks() ) {
+  if (isConnected_("anomaly") ) {
     Real32* buffer = reinterpret_cast<Real32*>(out->getData().getBuffer());
-    buffer[0] = tm_->anomaly;
+    buffer[0] = tm_->anomaly; //only the first field is valid
     NTA_DEBUG << "anomaly " << *out << std::endl;
   }
   out = getOutput("predictiveCells");
-  if (out && out->hasOutgoingLinks() ) {
+  if (isConnected_("predictiveCells") ) {
     out->getData().getSDR() = tm_->getPredictiveCells();
     NTA_DEBUG << "predictive " << *out << std::endl;
   }

src/htm/regions/TMRegion.hpp

@@ -182,7 +182,7 @@ class TMRegion : public RegionImpl, Serializable {
     Size iter;
   } args_;
 
-
+  bool isConnected_(std::string name) const;
 
   computeCallbackFunc computeCallback_;
   std::unique_ptr<TemporalMemory> tm_;