Skip to content

Commit 8f7a81e

Browse files
Remove the -Werror flag.
The compiler flag "-Werror" converts all warnings into errors. This was good back when we had CI & prebuilt binaries, but now that the best advice is for users to build from source this is causing problems. Deprecation warnings in particular are making the library un-installable, despite the fact that the deprecated functions are still present.
1 parent f19bd21 commit 8f7a81e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

CommonCompilerConfig.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,7 @@ else()
279279
set(cxx_flags_unoptimized ${cxx_flags_unoptimized} ${stdlib_cxx})
280280

281281
set(cxx_flags_unoptimized ${cxx_flags_unoptimized} ${stdlib_common} -fdiagnostics-show-option)
282-
set (internal_compiler_warning_flags ${internal_compiler_warning_flags} -Werror -Wextra -Wreturn-type -Wunused -Wno-unused-variable -Wno-unused-parameter -Wno-missing-field-initializers)
282+
set (internal_compiler_warning_flags ${internal_compiler_warning_flags} -Wextra -Wreturn-type -Wunused -Wno-unused-variable -Wno-unused-parameter -Wno-missing-field-initializers)
283283

284284
CHECK_CXX_COMPILER_FLAG(-m${BITNESS} compiler_supports_machine_option)
285285
if (compiler_supports_machine_option)
@@ -358,7 +358,7 @@ else()
358358
set(debug_specific_linker_flags)
359359

360360
if("${CMAKE_BUILD_TYPE}" STREQUAL "Debug")
361-
set (debug_specific_compile_flags ${debug_specific_compile_flags} -g)
361+
set (debug_specific_compile_flags ${debug_specific_compile_flags} -g -Werror)
362362

363363
set(debug_specific_linker_flags ${debug_specific_linker_flags} -O0)
364364

0 commit comments

Comments
 (0)