Skip to content

Commit 3f411c8

Browse files
committed
scripts/github-actions: build-hext-node-macos: monkey-patch node-abi to report proper ABI version for 24.0.0
1 parent 23847d2 commit 3f411c8

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

scripts/github-actions/macos/build-hext-node-macos.sh

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,11 @@ OUTD="$( cd "$NODE_OUT" >/dev/null && pwd )"
1313
cd "$LIBHEXTD/bindings/nodejs"
1414
npm install
1515
npm install prebuild
16+
17+
# Fix for "node-abi@3.75.0, node-abi@4.8.0 ABI version mismatch for Node 24.0.0 (v134 vs v137)"
18+
# https://github.com/electron/node-abi/issues/208
19+
sed -i 's/"abi": "134"/"abi": "137"/' $(find . -wholename "*node-abi/abi_registry.json")
20+
1621
npx prebuild \
1722
-t "$HEXT_NODE_API_VERSION1" \
1823
-t "$HEXT_NODE_API_VERSION2" \
@@ -31,6 +36,9 @@ npx prebuild \
3136
--CDCMAKE_BUILD_TYPE=Release
3237

3338

39+
ls -1 prebuilds/
40+
41+
3442
cd prebuilds
3543
for i in *.tar.gz ; do
3644
tar xf "$i"

0 commit comments

Comments
 (0)