Migrate and fix all ESLint issues. All lint configs are ESM now (#512)

NullVoxPopuli · web-flow · commit 953c899eb6d7 · 2026-01-23T13:06:06.000-05:00
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/vertical-collection/.eslintignore b/vertical-collection/.eslintignore
diff --git a/vertical-collection/.eslintrc.js b/vertical-collection/.eslintrc.js
diff --git a/vertical-collection/.prettierrc.mjs b/vertical-collection/.prettierrc.mjs
@@ -1,6 +1,4 @@
-'use strict';
-
-module.exports = {
+export default {
   plugins: ['prettier-plugin-ember-template-tag'],
   overrides: [
     {
diff --git a/vertical-collection/.stylelintrc.mjs b/vertical-collection/.stylelintrc.mjs
@@ -1,6 +1,4 @@
-'use strict';
-
-module.exports = {
+export default {
   extends: ['stylelint-config-standard', 'stylelint-prettier/recommended'],
   rules: {
     'selector-class-pattern': null,
diff --git a/vertical-collection/.template-lintrc.mjs b/vertical-collection/.template-lintrc.mjs
@@ -1,6 +1,4 @@
-'use strict';
-
-module.exports = {
+export default {
   extends: 'recommended',
   rules: {
     'no-attrs-in-components': false,
diff --git a/vertical-collection/addon/-private/data-view/radar/radar.js b/vertical-collection/addon/-private/data-view/radar/radar.js
@@ -130,7 +130,7 @@ export default class Radar {
 
     // In older versions of Ember/IE, binding anything on an object in the template
     // adds observers which creates __ember_meta__
-    this.__ember_meta__ = null; // eslint-disable-line camelcase
+    this.__ember_meta__ = null;
 
     if (DEBUG) {
       this._debugDidUpdate = null;
diff --git a/vertical-collection/addon/-private/data-view/utils/supports-passive.js b/vertical-collection/addon/-private/data-view/utils/supports-passive.js
@@ -9,7 +9,7 @@ try {
   });
 
   window.addEventListener('test', null, opts);
-} catch (e) {
+} catch {
   // do nothing
 }
 
diff --git a/vertical-collection/addon/components/vertical-collection.gjs b/vertical-collection/addon/components/vertical-collection.gjs
@@ -429,7 +429,7 @@ class VerticalCollection extends Component.extend({
 
     if (DEBUG) {
       if (this.__visualization) {
-        console.info('destroying visualization'); // eslint-disable-line no-console
+        console.info('destroying visualization');
         this.__visualization.destroy();
         this.__visualization = null;
       }
@@ -555,7 +555,7 @@ class VerticalCollection extends Component.extend({
         //
         if (this.debugVis !== true) {
           if (this.__visualization !== null) {
-            console.info('tearing down existing visualization'); // eslint-disable-line no-console
+            console.info('tearing down existing visualization');
             this.__visualization.destroy();
             this.__visualization = null;
           }
diff --git a/vertical-collection/babel.config.mjs b/vertical-collection/babel.config.mjs
@@ -0,0 +1,3 @@
+export default {
+  plugins: [],
+};
diff --git a/vertical-collection/eslint.config.mjs b/vertical-collection/eslint.config.mjs
@@ -0,0 +1,138 @@
+/**
+ * Debugging:
+ *   https://eslint.org/docs/latest/use/configure/debug
+ *  ----------------------------------------------------
+ *
+ *   Print a file's calculated configuration
+ *
+ *     npx eslint --print-config path/to/file.js
+ *
+ *   Inspecting the config
+ *
+ *     npx eslint --inspect-config
+ *
+ */
+import babelParser from '@babel/eslint-parser/experimental-worker';
+import js from '@eslint/js';
+import { defineConfig, globalIgnores } from 'eslint/config';
+import prettier from 'eslint-config-prettier';
+import ember from 'eslint-plugin-ember/recommended';
+import importPlugin from 'eslint-plugin-import';
+import n from 'eslint-plugin-n';
+import globals from 'globals';
+
+const esmParserOptions = {
+  ecmaFeatures: { modules: true },
+  ecmaVersion: 'latest',
+};
+
+export default defineConfig([
+  globalIgnores([
+    'dist/',
+    'dist-*/',
+    'declarations/',
+    'coverage/',
+    '!**/.*',
+
+    // REMOVE IN THE V2 ADDON PR
+    // (these files won't exist)
+    'ember-cli-build.js',
+    'index.js',
+    'testem.js',
+    'tests/**/*',
+  ]),
+  js.configs.recommended,
+  prettier,
+  ember.configs.base,
+  ember.configs.gjs,
+  /**
+   * https://eslint.org/docs/latest/use/configure/configuration-files#configuring-linter-options
+   */
+  {
+    linterOptions: {
+      reportUnusedDisableDirectives: 'error',
+    },
+  },
+  {
+    files: ['**/*.js'],
+    languageOptions: {
+      parser: babelParser,
+    },
+  },
+  {
+    files: ['**/*.{js,gjs}'],
+    languageOptions: {
+      parserOptions: esmParserOptions,
+      globals: {
+        ...globals.browser,
+      },
+    },
+  },
+  {
+    files: ['src/**/*'],
+    plugins: {
+      import: importPlugin,
+    },
+    rules: {
+      // require relative imports use full extensions
+      'import/extensions': ['error', 'always', { ignorePackages: true }],
+
+      'ember/closure-actions': 'off',
+      'ember/no-get': 'off',
+      'ember/no-classic-components': 'off',
+      'ember/require-tagless-components': 'off',
+      'ember/no-classic-classes': 'off',
+      'ember/no-actions-hash': 'off',
+      'ember/no-runloop': 'off',
+    },
+  },
+  /**
+   * CJS node files
+   */
+  {
+    files: ['**/*.cjs'],
+    plugins: {
+      n,
+    },
+
+    languageOptions: {
+      sourceType: 'script',
+      ecmaVersion: 'latest',
+      globals: {
+        ...globals.node,
+      },
+    },
+  },
+  /**
+   * ESM node files
+   */
+  {
+    files: ['**/*.mjs'],
+    plugins: {
+      n,
+    },
+
+    languageOptions: {
+      sourceType: 'module',
+      ecmaVersion: 'latest',
+      parserOptions: esmParserOptions,
+      globals: {
+        ...globals.node,
+      },
+    },
+  },
+  // REMOVE IN THE V2 ADDON PR
+  // (these files moved to src)
+  {
+    files: ['addon/**/*'],
+    rules: {
+      'ember/closure-actions': 'off',
+      'ember/no-get': 'off',
+      'ember/no-classic-components': 'off',
+      'ember/require-tagless-components': 'off',
+      'ember/no-classic-classes': 'off',
+      'ember/no-actions-hash': 'off',
+      'ember/no-runloop': 'off',
+    },
+  },
+]);
diff --git a/vertical-collection/package.json b/vertical-collection/package.json
@@ -71,6 +71,7 @@
     "@ember/test-helpers": "~3.3.1",
     "@ember/test-waiters": "~3.1.0",
     "@embroider/test-setup": "^3.0.1",
+    "@eslint/js": "^9.39.2",
     "@glimmer/component": "^1.0.0",
     "@glimmer/tracking": "^1.0.0",
     "@warp-drive/build-config": "4.13.0-alpha.8",
@@ -94,20 +95,22 @@
     "ember-source-channel-url": "^3.0.0",
     "ember-template-lint": "^5.11.2",
     "ember-try": "^4.0.0",
-    "eslint": "^8.47.0",
-    "eslint-config-prettier": "^9.0.0",
-    "eslint-plugin-ember": "^11.10.0",
-    "eslint-plugin-n": "^16.0.1",
+    "eslint": "^9.39.2",
+    "eslint-config-prettier": "^10.1.8",
+    "eslint-plugin-ember": "^12.7.5",
+    "eslint-plugin-import": "^2.32.0",
+    "eslint-plugin-n": "^17.23.2",
     "eslint-plugin-prettier": "^5.0.0",
     "eslint-plugin-qunit": "^8.0.0",
+    "globals": "^16.5.0",
     "loader.js": "^4.7.0",
-    "prettier": "^3.0.2",
+    "prettier": "^3.8.1",
     "prettier-plugin-ember-template-tag": "^2.0.6",
     "qunit": "^2.19.4",
     "qunit-dom": "^3.5.0",
-    "stylelint": "^15.10.3",
-    "stylelint-config-standard": "^34.0.0",
-    "stylelint-prettier": "^4.0.2",
+    "stylelint": "^17.0.0",
+    "stylelint-config-standard": "^40.0.0",
+    "stylelint-prettier": "^5.0.3",
     "webpack": "^5.88.2"
   },
   "engines": {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,4 @@`
`1`		`-'use strict';`
`2`		`-`
`3`		`-module.exports = {`
	`1`	`+export default {`
`4`	`2`	`plugins: ['prettier-plugin-ember-template-tag'],`
`5`	`3`	`overrides: [`
`6`	`4`	`{`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ try {`
`9`	`9`	`});`
`10`	`10`
`11`	`11`	`window.addEventListener('test', null, opts);`
`12`		`-} catch (e) {`
	`12`	`+} catch {`
`13`	`13`	`// do nothing`
`14`	`14`	`}`
`15`	`15`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+export default {`
	`2`	`+ plugins: [],`
	`3`	`+};`