.

Author: gildesmarais

.rubocop.yml

@@ -1,4 +1,4 @@
-require:
+plugins:
   - rubocop-performance
   - rubocop-rspec
   - rubocop-rake
@@ -12,9 +12,6 @@ AllCops:
     - '**/*.yaml'
     - '**/.tool-versions'
 
-Style/Documentation:
-  Enabled: false
-
 Metrics/BlockLength:
   Exclude:
     - Rakefile
@@ -28,6 +25,7 @@ Layout/ClassStructure:
   Enabled: true
 
 Style/Documentation:
+  Enabled: false
   AllowedConstants:
     - App
 

app/xml_builder.rb

@@ -10,7 +10,6 @@ module XmlBuilder
         Unable to extract content from %<url>s using the %<strategy>s strategy.
         The site may rely on JavaScript, block automated requests, or expose a structure that needs a different parser.
       DESC
-
       EMPTY_FEED_ITEM_TEMPLATE = <<~DESC
         No entries were extracted from %<url>s.
         Possible causes:
@@ -21,7 +20,6 @@ module XmlBuilder
 
         Try another strategy or reach out to the site owner.
       DESC
-
       class << self
         def build_rss_feed(title:, description:, link: nil, items: [], timestamp: nil)
           current_time = timestamp || Time.now
@@ -38,57 +36,61 @@ def build_rss_feed(title:, description:, link: nil, items: [], timestamp: nil)
         end
 
         def build_error_feed(message:, title: 'Error')
-          now = Time.now
-          build_rss_feed(
+          build_single_item_feed(
             title:,
             description: "Failed to generate feed: #{message}",
-            items: [
-              {
-                title:,
-                description: message,
-                pubDate: now
-              }
-            ],
-            timestamp: now
+            item: {
+              title:,
+              description: message
+            }
           )
         end
 
         def build_access_denied_feed(url)
-          now = Time.now
-          build_rss_feed(
+          build_single_item_feed(
             title: 'Access Denied',
             description: 'This URL is not allowed for public auto source generation.',
-            items: [
-              {
-                title: 'Access Denied',
-                description: "URL '#{url}' is not in the allowed list for public auto source.",
-                pubDate: now
-              }
-            ],
-            timestamp: now
+            item: {
+              title: 'Access Denied',
+              description: "URL '#{url}' is not in the allowed list for public auto source."
+            }
           )
         end
 
         def build_empty_feed_warning(url:, strategy:, site_title: nil)
-          now = Time.now
-          build_rss_feed(
-            title: site_title ? "#{site_title} - Content Extraction Issue" : 'Content Extraction Issue',
+          feed_title = site_title ? "#{site_title} - Content Extraction Issue" : 'Content Extraction Issue'
+          build_single_item_feed(
+            title: feed_title,
             description: format(EMPTY_FEED_DESCRIPTION_TEMPLATE, url:, strategy:),
-            link: url,
-            items: [
-              {
-                title: 'Content Extraction Failed',
-                description: format(EMPTY_FEED_ITEM_TEMPLATE, url:),
-                link: url,
-                pubDate: now
-              }
-            ],
-            timestamp: now
+            item: { title: 'Content Extraction Failed', description: format(EMPTY_FEED_ITEM_TEMPLATE, url:),
+                    link: url },
+            link: url
           )
         end
 
         private
 
+        def build_single_item_feed(title:, description:, item:, link: nil)
+          timestamp = Time.now
+          build_rss_feed(
+            title:,
+            description:,
+            link:,
+            items: [feed_item(item, timestamp:)],
+            timestamp:
+          )
+        end
+
+        def feed_item(item, timestamp:)
+          feed_item = {
+            title: item[:title],
+            description: item[:description],
+            pubDate: timestamp
+          }
+          feed_item[:link] = item[:link] if item[:link]
+          feed_item
+        end
+
         def build_channel(xml, title:, description:, link:, now:)
           xml.title(title.to_s)
           xml.description(description.to_s)
@@ -100,27 +102,18 @@ def build_channel(xml, title:, description:, link:, now:)
         def build_items(xml, items, default_pub_date:)
           items.each do |item|
             xml.item do
-              if (title = item[:title])
-                xml.title(title.to_s)
-              end
-
-              if (description = item[:description])
-                xml.description(description.to_s)
-              end
-
-              if (link = item[:link])
-                xml.link(link.to_s)
-              end
-
-              if (pub_date = item[:pubDate])
-                xml.pubDate(format_pub_date(pub_date))
-              else
-                xml.pubDate(default_pub_date)
-              end
+              append_text_node(xml, :title, item[:title])
+              append_text_node(xml, :description, item[:description])
+              append_text_node(xml, :link, item[:link])
+              xml.pubDate(format_pub_date(item[:pubDate] || default_pub_date))
             end
           end
         end
 
+        def append_text_node(xml, node_name, value)
+          xml.public_send(node_name, value.to_s) if value
+        end
+
         def format_pub_date(pub_date)
           pub_date.is_a?(Time) ? pub_date.rfc2822 : pub_date.to_s
         end

frontend/tsconfig.json

@@ -1,7 +1,7 @@
 {
   "extends": "astro/tsconfigs/strict",
   "compilerOptions": {
-    "types": ["vitest/globals", "@testing-library/jest-dom", "msw", "@playwright/test"]
+    "types": ["vitest/globals", "@testing-library/jest-dom", "msw"]
   },
   "include": ["astro.config.mjs", "src", "tests", "playwright.config.ts"]
 }