unify ci workflows

Author: gildesmarais

.github/workflows/test_build_push.yml .github/workflows/ci.yml.github/workflows/test_build_push.yml renamed to .github/workflows/ci.yml

@@ -1,13 +1,21 @@
-name: test, docker build & push
+name: CI
 
-on: [push]
+on:
+  push:
+  pull_request:
+  workflow_dispatch:
+
+concurrency:
+  group: ci-${{ github.ref }}
+  cancel-in-progress: true
 
 jobs:
   hadolint:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v5
-      - run: docker run --rm -i hadolint/hadolint < Dockerfile
+      - name: Lint Dockerfile
+        run: docker run --rm -i hadolint/hadolint < Dockerfile
 
   ruby:
     runs-on: ubuntu-latest
@@ -16,106 +24,98 @@ jobs:
 
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version-file: '.tool-versions'
+          ruby-version-file: ".tool-versions"
           bundler-cache: true
 
-      - run: bundle exec rubocop -F
-      - run: bundle exec yard doc --fail-on-warning --no-output
+      - name: Run RuboCop
+        run: bundle exec rubocop -F
+
+      - name: Verify Yard documentation
+        run: bundle exec yard doc --fail-on-warning --no-output
+
+      - name: Run RSpec
+        run: bundle exec rspec
+
+      - name: Upload coverage report
+        uses: actions/upload-artifact@v4
+        if: always()
+        with:
+          name: coverage-report
+          path: coverage/
+          retention-days: 30
 
   frontend:
     runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: frontend
     steps:
       - uses: actions/checkout@v5
 
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
-          node-version-file: '.tool-versions'
-          cache: "npm"
+          node-version-file: ".tool-versions"
+          cache: npm
           cache-dependency-path: frontend/package-lock.json
 
-      - name: Setup Ruby
-        uses: ruby/setup-ruby@v1
-        with:
-          ruby-version-file: '.tool-versions'
-          bundler-cache: true
-
       - name: Install dependencies
-        run: |
-          cd frontend
-          npm ci
-          cd ..
-          bundle install
+        run: npm ci
+
+      - name: Check formatting
+        run: npm run format:check
+
+      - name: Audit dependencies
+        run: npm audit --audit-level=moderate
 
       - name: Run frontend tests
-        run: |
-          cd frontend
-          npm run test:ci
+        run: npm run test:ci
 
       - name: Build frontend
-        run: |
-          cd frontend
-          npm run build
+        run: npm run build
 
       - name: Verify build output
         run: |
-          ls -la frontend/dist/
-          test -f frontend/dist/index.html
-          test -f frontend/dist/gallery/index.html
+          grep -q "html2rss-web" dist/index.html
+          grep -q "Feed Gallery" dist/gallery/index.html
 
-  rspec:
+  docker-test:
+    if: github.event_name == 'push'
+    needs:
+      - hadolint
+      - ruby
+      - frontend
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v5
 
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version-file: '.tool-versions'
+          ruby-version-file: ".tool-versions"
           bundler-cache: true
 
-      - run: bundle exec rspec
-
-      - name: Upload coverage report
-        uses: actions/upload-artifact@v4
-        if: always()
-        with:
-          name: coverage-report
-          path: coverage/
-          retention-days: 30
-
-  docker-test:
-    needs: [hadolint, frontend]
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v5
-      - uses: ruby/setup-ruby@v1
-        with:
-          ruby-version-file: '.tool-versions'
-          bundler-cache: true
-      - name: Setup Node.js for Docker build
+      - name: Setup Node.js for Docker smoke test
         uses: actions/setup-node@v4
         with:
-          node-version-file: '.tool-versions'
-          cache: "npm"
+          node-version-file: ".tool-versions"
+          cache: npm
           cache-dependency-path: frontend/package-lock.json
+
       - name: Install frontend dependencies
-        run: |
-          cd frontend
-          npm ci
+        run: npm ci
+        working-directory: frontend
+
       - name: Build frontend
-        run: |
-          cd frontend
-          npm run build
-      - run: |
-          bundle exec rake
+        run: npm run build
+        working-directory: frontend
 
-  docker-push:
-    if: ${{ github.ref == 'refs/heads/master' }}
+      - name: Run Docker smoke test
+        run: bundle exec rake
+
+  docker-publish:
+    if: github.event_name == 'push' && github.ref == 'refs/heads/master'
     needs:
       - docker-test
-      - hadolint
-      - ruby
-      - frontend
     runs-on: ubuntu-latest
     permissions:
       contents: read
@@ -130,19 +130,17 @@ jobs:
       - name: Setup Node.js for Docker build
         uses: actions/setup-node@v4
         with:
-          node-version-file: '.tool-versions'
-          cache: "npm"
+          node-version-file: ".tool-versions"
+          cache: npm
           cache-dependency-path: frontend/package-lock.json
 
       - name: Install frontend dependencies
-        run: |
-          cd frontend
-          npm ci
+        run: npm ci
+        working-directory: frontend
 
       - name: Build frontend
-        run: |
-          cd frontend
-          npm run build
+        run: npm run build
+        working-directory: frontend
 
       - name: Set up QEMU
         uses: docker/setup-qemu-action@v3