Skip to content

Commit e5aea3e

Browse files
committed
refactor: remove facade
Refactored RSS feed handling in app.rb to eliminate the Html2rssFacade. Merged configuration directly into request handlers, simplifying the feed generation process. This change enhances performance by reducing method calls and improves readability by consolidating logic. Removed unused helper files related to the facade, cleaning up the codebase. Signed-off-by: Gil Desmarais <[email protected]>
1 parent 1135981 commit e5aea3e

File tree

5 files changed

+2
-143
lines changed

5 files changed

+2
-143
lines changed

app.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ def self.development? = ENV['RACK_ENV'] == 'development'
9898

9999
HttpCache.expires(response, feed.channel.ttl.to_i * 60, cache_control: 'public')
100100

101-
feed.to_xml
101+
feed.to_s
102102
end
103103

104104
r.on String do |config_name_with_ext|
@@ -115,7 +115,7 @@ def self.development? = ENV['RACK_ENV'] == 'development'
115115

116116
HttpCache.expires(response, feed.channel.ttl.to_i * 60, cache_control: 'public')
117117

118-
feed.to_xml
118+
feed.to_s
119119
end
120120
end
121121

app/html2rss_facade.rb

Lines changed: 0 additions & 77 deletions
This file was deleted.

helpers/handle_html2rss_configs.rb

Lines changed: 0 additions & 17 deletions
This file was deleted.

helpers/handle_local_config_feeds.rb

Lines changed: 0 additions & 17 deletions
This file was deleted.

spec/html2rss/web/app/html2rss_facade_spec.rb

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)