You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/CONTRIBUTING.md
+7-7Lines changed: 7 additions & 7 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -24,25 +24,25 @@ Before you get your hands dirty, please [search](https://github.com/http-party/h
24
24
Follow these steps to get going.
25
25
26
26
1.[Install the latest version of Node.js](https://nodejs.org/en/download).
27
-
- If you're new to installing Node, a tool like [nvm](https://github.com/creationix/nvm#install-script) can help you manage multiple version installations.
27
+
- If you're new to installing Node, a tool like [nvm](https://github.com/creationix/nvm#install-script) can help you manage multiple version installations.
28
28
1. Follow [Github's documentation](https://help.github.com/articles/fork-a-repo/) on setting up Git, forking and cloning.
29
29
1. Create a new branch in your fork, giving it a descriptive name
30
30
1. Execute `npm install` to install the prod and dev dependencies
31
-
- Do not use `yarn install` for development, as it may not get the same package versions as other developers.
31
+
- Do not use `yarn install` for development, as it may not get the same package versions as other developers.
32
32
1. Make your changes and add them via `git add`.
33
-
-**Tests are required** for any non-trivial code change. If you're having trouble making tests, go ahead and open the pull request and we can help
34
-
- Keep your PR focused. Don't fix multiple things at once, and don't upgrade dependencies unless necessary.
33
+
-**Tests are required** for any non-trivial code change. If you're having trouble making tests, go ahead and open the pull request and we can help
34
+
- Keep your PR focused. Don't fix multiple things at once, and don't upgrade dependencies unless necessary.
35
35
1. Before committing, run `npm test`
36
-
- Tests will also run on your PR, but running them locally will let you catch problems ahead-of-time.
36
+
- Tests will also run on your PR, but running them locally will let you catch problems ahead-of-time.
37
37
1. Commit your changes.
38
-
- See [How to Write a Git Commit Message](https://chris.beams.io/posts/git-commit/).
38
+
- See [How to Write a Git Commit Message](https://chris.beams.io/posts/git-commit/).
39
39
1. Push your changes to your fork.
40
40
1. Now on [http-party/http-server](https://github.com/http-party/http-server), you should see a notification about your recent changes in your fork's branch, with a green button to create a pull request. Click the button.
41
41
1. Describe your changes in detail here, following the template. Once you're satisfied, submit the form.
42
42
1. Be patient while your PR is reviewed. This can take a while. We may request changes, but don't be afraid to question them.
43
43
1. Your PR might become conflicted with the code in `master`. If this is the case, you will need to [update your PR](#up-to-date) and resolve your conflicts.
44
44
1. You don't need to make a new PR to any needed changes. Instead, commit on top of your changes, and push these to your fork's branch. The PR will be updated, and CI will re-run.
45
-
-**Please do not rebase and force-push**, it ruins the git history
45
+
-**Please do not rebase and force-push**, it ruins the git history
0 commit comments