feat: add flag --content-type

Adds a flag to change the default Content-Type header value to something
other than application/octet-stream. This feature may not have the
demand that it would have before the internalization of ecstatic,
however contentType was already managed as an option and there just
wasn't a flag in front of it, so I figured I'd finish what was started.

Co-authored-by: howardroark <[email protected]>

Author: KernelDeimos

bin/http-server

@@ -42,6 +42,7 @@ if (argv.h || argv.help) {
     '',
     '  -e --ext     Default file extension if none supplied [none]',
     '  -s --silent  Suppress log messages from output',
+    '  --content-type     Default content type for unknown file types [application/octet-stream]',
     '  --cors[=headers]   Enable CORS via the "Access-Control-Allow-Origin" header',
     '                     When enabled, sets Access-Control-Allow-Origin to "*"',
     '                     Optional value adds to Access-Control-Allow-Headers',
@@ -169,6 +170,7 @@ function listen(port) {
     proxyOptions: proxyOptions,
     showDotfiles: argv.dotfiles,
     mimetypes: argv.mimetypes,
+    contentType: argv['content-type'],
     username: argv.username || process.env.NODE_HTTP_SERVER_USERNAME,
     password: argv.password || process.env.NODE_HTTP_SERVER_PASSWORD,
     headers: {}

lib/http-server.js

@@ -75,7 +75,7 @@ function HttpServer(options) {
       : options.ext;
   }
   this.contentType = options.contentType ||
-    this.ext === 'html' ? 'text/html' : 'application/octet-stream';
+    (this.ext === 'html' ? 'text/html' : 'application/octet-stream');
 
   var before = options.before ? options.before.slice() : [];
 

test/cli.test.js

@@ -177,3 +177,22 @@ test('empty header value is allowed (RFC 7230)', (t) => {
     { 'x-http-server-test-empty-a': '', 'x-http-server-test-empty-b': '' }
   );
 });
+
+test('setting default content-type via cli', (t) => {
+  t.plan(4);
+
+  getPort().then((port) => {
+    const root = path.resolve(__dirname, 'public/');
+    const options = [root, '--port', port, '--content-type', 'text/custom'];
+    const server = startServer(options);
+
+    tearDown(server, t);
+
+    server.stdout.on('data', (msg) => {
+      checkServerIsRunning(`http://localhost:${port}/f_f`, msg, t, (err, res) => {
+        t.error(err);
+        t.equal(res.headers['content-type'], 'text/custom; charset=UTF-8');
+      });
+    });
+  });
+});