PR comments (small nits) fixed

Author: rylev

examples/server.rs

@@ -7,10 +7,8 @@ use async_std::io::{self, Read, Write};
 use async_std::net::{self, TcpStream};
 use async_std::prelude::*;
 use async_std::task::{self, Context, Poll};
-use http_types::{
-    headers::{HeaderName, HeaderValue},
-    Response, StatusCode,
-};
+use http_types::headers::{HeaderName, HeaderValue};
+use http_types::{Response, StatusCode};
 
 async fn accept(addr: String, stream: TcpStream) -> Result<(), async_h1::Exception> {
     // println!("starting new connection from {}", stream.peer_addr()?);

src/client.rs

@@ -113,10 +113,9 @@ where
     use std::convert::TryFrom;
     let mut res = Response::new(StatusCode::try_from(code)?);
     for header in httparse_res.headers.iter() {
-        res.insert_header(
-            HeaderName::from_str(header.name)?,
-            HeaderValue::from_str(std::str::from_utf8(header.value)?)?,
-        )?;
+        let name = HeaderName::from_str(header.name)?;
+        let value = HeaderValue::from_str(std::str::from_utf8(header.value)?)?;
+        res.insert_header(name, value)?;
     }
 
     // Process the body if `Content-Length` was passed.

src/server.rs

@@ -386,16 +386,17 @@ where
     let method = httparse_req.method.ok_or_else(|| "No method found")?;
     let uri = httparse_req.path.ok_or_else(|| "No uri found")?;
     let uri = url::Url::parse(&format!("{}{}", addr, uri))?;
+
     let version = httparse_req.version.ok_or_else(|| "No version found")?;
     if version != HTTP_1_1_VERSION {
         return Err("Unsupported HTTP version".into());
     }
+
     let mut req = Request::new(Method::from_str(method)?, uri);
     for header in httparse_req.headers.iter() {
-        req.insert_header(
-            HeaderName::from_str(header.name)?,
-            HeaderValue::from_str(std::str::from_utf8(header.value)?)?,
-        )?;
+        let name = HeaderName::from_str(header.name)?;
+        let value = HeaderValue::from_str(std::str::from_utf8(header.value)?)?;
+        req.insert_header(name, value)?;
     }
 
     // Check for content-length, that determines determines whether we can parse
@@ -406,6 +407,7 @@ where
     };
     req.set_body(Body::from_reader(reader));
     req.set_len(len);
+
     Ok(Some(DecodedRequest::WithBody(req)))
 }