Skip to content

Commit d26570a

Browse files
committed
incorporate review feedback
1 parent 9fd5ea0 commit d26570a

File tree

3 files changed

+7
-21
lines changed

3 files changed

+7
-21
lines changed

src/chunked/decoder.rs

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -591,20 +591,10 @@ mod tests {
591591
let as_vec = trailers.iter().collect::<Vec<_>>();
592592

593593
assert_eq!(as_vec.len(), 1);
594-
let (header_name, header_values) = as_vec[0];
595-
assert_eq!(
596-
header_name,
597-
&"Expires"
598-
.parse::<http_types::headers::HeaderName>()
599-
.unwrap()
600-
);
601-
assert_eq!(header_values.iter().collect::<Vec<_>>().len(), 1);
602-
assert_eq!(
603-
header_values.last(),
604-
&"Wed, 21 Oct 2015 07:28:00 GMT"
605-
.parse::<http_types::headers::HeaderValue>()
606-
.unwrap()
607-
);
594+
let (trailer_name, trailer_values) = as_vec[0];
595+
assert_eq!(trailer_name, "Expires");
596+
assert_eq!(trailer_values.iter().count(), 1);
597+
assert_eq!(trailer_values.last(), "Wed, 21 Oct 2015 07:28:00 GMT");
608598
});
609599
}
610600
}

src/server/encode.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,8 @@ use std::pin::Pin;
55
use async_std::io;
66
use async_std::io::prelude::*;
77
use async_std::task::{Context, Poll};
8-
use http_types::{
9-
headers::{CONTENT_LENGTH, DATE, TRANSFER_ENCODING},
10-
Response,
11-
};
8+
use http_types::headers::{CONTENT_LENGTH, DATE, TRANSFER_ENCODING};
9+
use http_types::Response;
1210

1311
use crate::chunked::ChunkedEncoder;
1412
use crate::date::fmt_http_date;

tests/client.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,7 @@ async fn test_response_newlines() {
5757
let res = client::decode(response_fixture).await.unwrap();
5858

5959
pretty_assertions::assert_eq!(
60-
res.header(&headers::CONTENT_LENGTH)
61-
.unwrap()
62-
.last()
60+
res[headers::CONTENT_LENGTH]
6361
.as_str()
6462
.parse::<usize>()
6563
.unwrap(),

0 commit comments

Comments
 (0)