Merge pull request #85 from gdamjan/master

add test for response with newlines instead of \r\n

Author: yoshuawuyts

src/client/decode.rs

@@ -44,6 +44,9 @@ where
         if idx >= 3 && &buf[idx - 3..=idx] == [CR, LF, CR, LF] {
             break;
         }
+        if idx >= 1 && &buf[idx - 1..=idx] == [LF, LF] {
+            break;
+        }
     }
 
     // Convert our header buf into an httparse instance, and validate.

tests/client.rs

@@ -47,3 +47,23 @@ async fn test_multiple_header_values_for_same_header_name() {
 
     pretty_assertions::assert_eq!(res.header(&headers::SET_COOKIE).unwrap().len(), 2);
 }
+
+#[async_std::test]
+async fn test_response_newlines() {
+    let response_fixture = File::open(fixture_path("fixtures/response-newlines.txt"))
+        .await
+        .unwrap();
+
+    let res = client::decode(response_fixture).await.unwrap();
+
+    pretty_assertions::assert_eq!(
+        res.header(&headers::CONTENT_LENGTH)
+            .unwrap()
+            .last()
+            .unwrap()
+            .as_str()
+            .parse::<usize>()
+            .unwrap(),
+        78
+    );
+}

tests/fixtures/response-newlines.txt

@@ -0,0 +1,6 @@
+HTTP/1.1 200 OK
+content-length: 78
+date: {DATE}
+content-type: text/plain; charset=utf-8
+
+http specifies headers are separated with \r\n but many servers don't do that