Incorporate feedback from review

jbr · yoshuawuyts · jbr · commit f6a652813365 · 2020-11-28T14:39:00.000-08:00
Co-authored-by: Yoshua Wuyts &lt;yoshuawuyts@gmail.com&gt;
diff --git a/src/chunked/encoder.rs b/src/chunked/encoder.rs
@@ -26,9 +26,9 @@ fn max_bytes_to_read(buf_len: usize) -> usize {
     if buf_len < 6 {
         panic!("buffers of length {} are too small for this implementation. if this is a problem for you, please open an issue", buf_len);
     }
-    let max_bytes_of_hex_framing = // the maximum number of bytes that the hex representation of remaining bytes might take
-                (((buf_len - 5) as f64).log2() / 4f64).floor() as usize;
-    buf_len - 5 - max_bytes_of_hex_framing
+    // the maximum number of bytes that the hex representation of remaining bytes might take
+    let max_bytes_of_hex_framing = (((buf_len - 5) as f64).log2() / 4f64).floor();
+    buf_len - 5 - (max_bytes_of_hex_framing  as usize)
 }
 
 impl<R: Read + Unpin> Read for ChunkedEncoder<R> {

Original file line number	Diff line number	Diff line change
`@@ -26,9 +26,9 @@ fn max_bytes_to_read(buf_len: usize) -> usize {`
`26`	`26`	`if buf_len < 6 {`
`27`	`27`	`panic!("buffers of length {} are too small for this implementation. if this is a problem for you, please open an issue", buf_len);`
`28`	`28`	`}`
`29`		`- let max_bytes_of_hex_framing = // the maximum number of bytes that the hex representation of remaining bytes might take`
`30`		`- (((buf_len - 5) as f64).log2() / 4f64).floor() as usize;`
`31`		`- buf_len - 5 - max_bytes_of_hex_framing`
	`29`	`+ // the maximum number of bytes that the hex representation of remaining bytes might take`
	`30`	`+ let max_bytes_of_hex_framing = (((buf_len - 5) as f64).log2() / 4f64).floor();`
	`31`	`+ buf_len - 5 - (max_bytes_of_hex_framing as usize)`
`32`	`32`	`}`
`33`	`33`
`34`	`34`	`impl<R: Read + Unpin> Read for ChunkedEncoder<R> {`