finish native-client impl

Author: dignifiedquire

Cargo.toml

@@ -20,7 +20,7 @@ default = ["h1_client"]
 docs = ["h1_client"]
 h1_client = ["async-h1", "async-std", "async-native-tls"]
 native_client = ["curl_client", "wasm_client"]
-curl_client = ["isahc"]
+curl_client = ["isahc", "async-std"]
 wasm_client = ["js-sys", "web-sys", "wasm-bindgen", "wasm-bindgen-futures"]
 
 [dependencies]
@@ -30,12 +30,12 @@ log = "0.4.7"
 
 # h1-client
 async-h1 = { version = "1.0.0", optional = true }
-async-std = { version = "1.4.0", optional = true }
+async-std = { version = "1.4.0", default-features = false, optional = true }
 async-native-tls = { version = "0.3.1", optional = true }
 
 # isahc-client
 [target.'cfg(not(target_arch = "wasm32"))'.dependencies]
-isahc = { version = "0.8", git = "https://github.com/sagebind/isahc", optional = true, default-features = false, features = ["http2"]  }
+isahc = { version = "0.9", optional = true, default-features = false, features = ["http2"]  }
 
 # wasm-client
 [target.'cfg(target_arch = "wasm32")'.dependencies]

src/isahc.rs

@@ -2,6 +2,7 @@
 
 use super::{Body, HttpClient, Request, Response};
 
+use async_std::io::BufReader;
 use futures::future::BoxFuture;
 use isahc::http;
 
@@ -59,12 +60,10 @@ impl HttpClient for IsahcClient {
 
             let (parts, body) = res.into_parts();
 
-            // FIXME: isahc::Body is !Sync, making it impossible to pass to http::Response
-            unimplemented!();
-
-            // let body = Body::from_reader(body, body.len().map(|len| len as usize));
-            // let res = http::Response::from_parts(parts, body);
-            // Ok(res.into())
+            let len = body.len().map(|len| len as usize);
+            let body = Body::from_reader(BufReader::new(body), len);
+            let res = http::Response::from_parts(parts, body);
+            Ok(res.into())
         })
     }
 }