Merge pull request #80 from http-rs/headers-equality

Add equality checks between headers and strings

Author: yoshuawuyts

src/headers/header_name.rs

@@ -71,6 +71,30 @@ impl<'a> std::convert::TryFrom<&'a str> for HeaderName {
     }
 }
 
+impl PartialEq<str> for HeaderName {
+    fn eq(&self, other: &str) -> bool {
+        self.0 == other
+    }
+}
+
+impl<'a> PartialEq<&'a str> for HeaderName {
+    fn eq(&self, other: &&'a str) -> bool {
+        &self.0 == other
+    }
+}
+
+impl PartialEq<String> for HeaderName {
+    fn eq(&self, other: &String) -> bool {
+        &self.0 == other
+    }
+}
+
+impl<'a> PartialEq<&String> for HeaderName {
+    fn eq(&self, other: &&String) -> bool {
+        &&self.0 == other
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use super::*;
@@ -88,4 +112,13 @@ mod tests {
         assert_eq!(static_header, static_header);
         assert_eq!(non_static_header, non_static_header);
     }
+
+    #[test]
+    fn equality() {
+        let static_header = HeaderName::from_lowercase_str("hello");
+        assert_eq!(static_header, "hello");
+        assert_eq!(&static_header, "hello");
+        assert_eq!(static_header, String::from("hello"));
+        assert_eq!(static_header, &String::from("hello"));
+    }
 }

src/headers/header_value.rs

@@ -87,3 +87,27 @@ impl Display for HeaderValue {
         write!(f, "{}", self.inner)
     }
 }
+
+impl PartialEq<str> for HeaderValue {
+    fn eq(&self, other: &str) -> bool {
+        self.inner == other
+    }
+}
+
+impl<'a> PartialEq<&'a str> for HeaderValue {
+    fn eq(&self, other: &&'a str) -> bool {
+        &self.inner == other
+    }
+}
+
+impl PartialEq<String> for HeaderValue {
+    fn eq(&self, other: &String) -> bool {
+        &self.inner == other
+    }
+}
+
+impl<'a> PartialEq<&String> for HeaderValue {
+    fn eq(&self, other: &&String) -> bool {
+        &&self.inner == other
+    }
+}

src/headers/mod.rs

@@ -164,41 +164,27 @@ mod tests {
         let non_static_header = HeaderName::from_str("hello").unwrap();
 
         let mut headers = Headers::new();
+        headers.append(STATIC_HEADER, &["foo0"][..]).unwrap();
         headers
-            .append(STATIC_HEADER, &["foo0".parse().unwrap()][..])
+            .append(static_header.clone(), &["foo1"][..])
             .unwrap();
         headers
-            .append(static_header.clone(), &["foo1".parse().unwrap()][..])
-            .unwrap();
-        headers
-            .append(non_static_header.clone(), &["foo2".parse().unwrap()][..])
+            .append(non_static_header.clone(), &["foo2"][..])
             .unwrap();
 
         assert_eq!(
             &headers.get(&STATIC_HEADER).unwrap()[..],
-            &[
-                "foo0".parse().unwrap(),
-                "foo1".parse().unwrap(),
-                "foo2".parse().unwrap()
-            ][..]
+            &["foo0", "foo1", "foo2",][..]
         );
 
         assert_eq!(
             &headers.get(&static_header).unwrap()[..],
-            &[
-                "foo0".parse().unwrap(),
-                "foo1".parse().unwrap(),
-                "foo2".parse().unwrap()
-            ][..]
+            &["foo0", "foo1", "foo2",][..]
         );
 
         assert_eq!(
             &headers.get(&non_static_header).unwrap()[..],
-            &[
-                "foo0".parse().unwrap(),
-                "foo1".parse().unwrap(),
-                "foo2".parse().unwrap()
-            ][..]
+            &["foo0", "foo1", "foo2",][..]
         );
     }
 }