add generic from body conversion for Response

yoshuawuyts · yoshuawuyts · commit 70926d134277 · 2020-04-22T10:52:13.000+02:00
diff --git a/src/body.rs b/src/body.rs
@@ -234,12 +234,6 @@ impl<'a> From<&'a [u8]> for Body {
     }
 }
 
-impl From<()> for Body {
-    fn from(_: ()) -> Self {
-        Self::empty()
-    }
-}
-
 impl Read for Body {
     #[allow(missing_doc_code_examples)]
     fn poll_read(
diff --git a/src/response.rs b/src/response.rs
@@ -491,56 +491,30 @@ impl AsMut<Headers> for Response {
     }
 }
 
-impl From<Response> for Body {
-    fn from(res: Response) -> Body {
-        res.body
-    }
-}
-
 impl From<()> for Response {
     fn from(_: ()) -> Self {
         Response::new(StatusCode::NoContent)
     }
 }
 
-impl From<String> for Response {
-    fn from(s: String) -> Self {
-        let mut res = Response::new(StatusCode::Ok);
-        res.set_body(s);
-        res
-    }
-}
-
-impl<'a> From<&'a str> for Response {
-    fn from(s: &'a str) -> Self {
-        let mut res = Response::new(StatusCode::Ok);
-        res.set_body(s);
-        res
-    }
-}
-
-impl From<Vec<u8>> for Response {
-    fn from(b: Vec<u8>) -> Self {
-        let mut res = Response::new(StatusCode::Ok);
-        res.set_body(b);
-        res
+impl From<StatusCode> for Response {
+    fn from(s: StatusCode) -> Self {
+        Response::new(s)
     }
 }
 
-impl<'a> From<&'a [u8]> for Response {
-    fn from(b: &'a [u8]) -> Self {
+impl<T> From<T> for Response
+where
+    T: Into<Body>,
+{
+    fn from(value: T) -> Self {
+        let body: Body = value.into();
         let mut res = Response::new(StatusCode::Ok);
-        res.set_body(b);
+        res.set_body(body);
         res
     }
 }
 
-impl From<StatusCode> for Response {
-    fn from(s: StatusCode) -> Self {
-        Response::new(s)
-    }
-}
-
 impl IntoIterator for Response {
     type Item = (HeaderName, Vec<HeaderValue>);
     type IntoIter = headers::IntoIter;

Original file line number	Diff line number	Diff line change
`@@ -234,12 +234,6 @@ impl<'a> From<&'a [u8]> for Body {`
`234`	`234`	`}`
`235`	`235`	`}`
`236`	`236`
`237`		`-impl From<()> for Body {`
`238`		`- fn from(_: ()) -> Self {`
`239`		`- Self::empty()`
`240`		`- }`
`241`		`-}`
`242`		`-`
`243`	`237`	`impl Read for Body {`
`244`	`238`	`#[allow(missing_doc_code_examples)]`
`245`	`239`	`fn poll_read(`