Apply suggestions from code review

jbr · yoshuawuyts · web-flow · commit 7821e221f24c · 2020-08-07T13:06:00.000-07:00
keep the type_name a &amp;'static str

Co-authored-by: Yoshua Wuyts &lt;yoshuawuyts+github@gmail.com&gt;
diff --git a/src/error.rs b/src/error.rs
@@ -15,7 +15,7 @@ pub type Result<T> = std::result::Result<T, Error>;
 pub struct Error {
     error: anyhow::Error,
     status: crate::StatusCode,
-    type_name: Option<String>,
+    type_name: Option<&'static str>,
 }
 
 impl Error {
@@ -28,7 +28,7 @@ impl Error {
         Self {
             status,
             error: error.into(),
-            type_name: Some(std::any::type_name::<E>().to_string()),
+            type_name: Some(std::any::type_name::<E>()),
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ pub type Result<T> = std::result::Result<T, Error>;`
`15`	`15`	`pub struct Error {`
`16`	`16`	`error: anyhow::Error,`
`17`	`17`	`status: crate::StatusCode,`
`18`		`- type_name: Option<String>,`
	`18`	`+ type_name: Option<&'static str>,`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`impl Error {`
`@@ -28,7 +28,7 @@ impl Error {`
`28`	`28`	`Self {`
`29`	`29`	`status,`
`30`	`30`	`error: error.into(),`
`31`		`- type_name: Some(std::any::type_name::<E>().to_string()),`
	`31`	`+ type_name: Some(std::any::type_name::<E>()),`
`32`	`32`	`}`
`33`	`33`	`}`
`34`	`34`