now passes all

Author: yoshuawuyts

src/headers/header_value.rs

@@ -122,7 +122,11 @@ impl<'a> PartialEq<&String> for HeaderValue {
 }
 
 impl From<HeaderValues> for HeaderValue {
-    fn from(other: HeaderValues) -> Self {
-        other[0]
+    fn from(mut other: HeaderValues) -> Self {
+        other.inner.reverse();
+        other
+            .inner
+            .pop()
+            .expect("HeaderValues should contain at least one value")
     }
 }

src/headers/header_values.rs

@@ -10,7 +10,7 @@ use std::slice::SliceIndex;
 /// This always contains at least one header value.
 #[derive(Debug, Clone)]
 pub struct HeaderValues {
-    inner: Vec<HeaderValue>,
+    pub(crate) inner: Vec<HeaderValue>,
 }
 
 impl HeaderValues {
@@ -30,7 +30,7 @@ impl HeaderValues {
     }
 
     /// Returns the last `HeaderValue`.
-    pub fn last(&mut self) -> &HeaderValue {
+    pub fn last(&self) -> &HeaderValue {
         self.inner
             .last()
             .expect("HeaderValues must always contain at least one value")
@@ -66,7 +66,7 @@ impl FromIterator<HeaderValue> for HeaderValues {
     {
         let iter = iter.into_iter();
         let mut output = Vec::with_capacity(iter.size_hint().0);
-        for v in output {
+        for v in iter {
             output.push(v);
         }
         HeaderValues { inner: output }
@@ -147,13 +147,3 @@ impl<'a> IntoIterator for &'a HeaderValues {
         self.iter()
     }
 }
-
-// impl<'a> IntoIterator for &'a mut HeaderValues {
-//     type Item = &'a HeaderValue;
-//     type IntoIter = ValuesMut<'a>;
-
-//     #[inline]
-//     fn into_iter(self) -> Self::IntoIter {
-//         self.iter_mut()
-//     }
-// }

src/headers/values.rs

@@ -64,8 +64,9 @@ impl<'a> Iterator for Values<'a> {
 
     #[inline]
     fn size_hint(&self) -> (usize, Option<usize>) {
-        self.inner
-            .map(|inner| inner.size_hint())
-            .unwrap_or((0, None))
+        match self.inner.as_ref() {
+            Some(inner) => inner.size_hint(),
+            None => (0, None),
+        }
     }
 }

src/hyperium_http.rs

@@ -71,7 +71,7 @@ fn headers_to_hyperium_headers(headers: &mut Headers, hyperium_headers: &mut htt
         let name = format!("{}", name).into_bytes();
         let name = http::header::HeaderName::from_bytes(&name).unwrap();
 
-        for value in values {
+        for value in values.iter() {
             let value = format!("{}", value).into_bytes();
             let value = http::header::HeaderValue::from_bytes(&value).unwrap();
             hyperium_headers.append(&name, value);