Convert Into impls to From impls

tmfink · tmfink · commit 81a57934e2b4 · 2020-03-15T21:59:13.000-04:00
To quote the `std::convert::From` doc:

&gt; One should always prefer implementing From over Into because
&gt; implementing From automatically provides one with an implementation of
&gt; Into thanks to the blanket implementation in the standard library.
diff --git a/src/request.rs b/src/request.rs
@@ -493,9 +493,9 @@ impl AsMut<Headers> for Request {
     }
 }
 
-impl Into<Body> for Request {
-    fn into(self) -> Body {
-        self.body
+impl From<Request> for Body {
+    fn from(req: Request) -> Body {
+        req.body
     }
 }
 
diff --git a/src/response.rs b/src/response.rs
@@ -459,9 +459,9 @@ impl AsMut<Headers> for Response {
     }
 }
 
-impl Into<Body> for Response {
-    fn into(self) -> Body {
-        self.body
+impl From<Response> for Body {
+    fn from(res: Response) -> Body {
+        res.body
     }
 }
 
diff --git a/src/status_code.rs b/src/status_code.rs
@@ -460,15 +460,9 @@ impl StatusCode {
     }
 }
 
-impl Into<u16> for StatusCode {
-    fn into(self) -> u16 {
-        self as u16
-    }
-}
-
-impl Into<u16> for &StatusCode {
-    fn into(self) -> u16 {
-        *self as u16
+impl From<StatusCode> for u16 {
+    fn from(code: StatusCode) -> u16 {
+        code as u16
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -493,9 +493,9 @@ impl AsMut<Headers> for Request {`
`493`	`493`	`}`
`494`	`494`	`}`
`495`	`495`
`496`		`-impl Into<Body> for Request {`
`497`		`- fn into(self) -> Body {`
`498`		`- self.body`
	`496`	`+impl From<Request> for Body {`
	`497`	`+ fn from(req: Request) -> Body {`
	`498`	`+ req.body`
`499`	`499`	`}`
`500`	`500`	`}`
`501`	`501`
Original file line number	Diff line number	Diff line change
`@@ -459,9 +459,9 @@ impl AsMut<Headers> for Response {`
`459`	`459`	`}`
`460`	`460`	`}`
`461`	`461`
`462`		`-impl Into<Body> for Response {`
`463`		`- fn into(self) -> Body {`
`464`		`- self.body`
	`462`	`+impl From<Response> for Body {`
	`463`	`+ fn from(res: Response) -> Body {`
	`464`	`+ res.body`
`465`	`465`	`}`
`466`	`466`	`}`
`467`	`467`
Original file line number	Diff line number	Diff line change
`@@ -460,15 +460,9 @@ impl StatusCode {`
`460`	`460`	`}`
`461`	`461`	`}`
`462`	`462`
`463`		`-impl Into<u16> for StatusCode {`
`464`		`- fn into(self) -> u16 {`
`465`		`- self as u16`
`466`		`- }`
`467`		`-}`
`468`		`-`
`469`		`-impl Into<u16> for &StatusCode {`
`470`		`- fn into(self) -> u16 {`
`471`		`- *self as u16`
	`463`	`+impl From<StatusCode> for u16 {`
	`464`	`+ fn from(code: StatusCode) -> u16 {`
	`465`	`+ code as u16`
`472`	`466`	`}`
`473`	`467`	`}`
`474`	`468`