apply feedback from review

yoshuawuyts · yoshuawuyts · commit 9325743f47b2 · 2020-11-13T15:08:53.000+01:00
diff --git a/src/headers/to_header_values.rs b/src/headers/to_header_values.rs
@@ -54,21 +54,15 @@ impl ToHeaderValues for String {
     type Iter = option::IntoIter<HeaderValue>;
 
     fn to_header_values(&self) -> crate::Result<Self::Iter> {
-        let value = self
-            .parse()
-            .map_err(|err| io::Error::new(io::ErrorKind::Other, err))?;
-        Ok(Some(value).into_iter())
+        self.as_str().to_header_values()
     }
 }
 
 impl ToHeaderValues for &String {
     type Iter = option::IntoIter<HeaderValue>;
 
     fn to_header_values(&self) -> crate::Result<Self::Iter> {
-        let value = self
-            .parse()
-            .map_err(|err| io::Error::new(io::ErrorKind::Other, err))?;
-        Ok(Some(value).into_iter())
+        self.as_str().to_header_values()
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -54,21 +54,15 @@ impl ToHeaderValues for String {`
`54`	`54`	`type Iter = option::IntoIter<HeaderValue>;`
`55`	`55`
`56`	`56`	`fn to_header_values(&self) -> crate::Result<Self::Iter> {`
`57`		`- let value = self`
`58`		`- .parse()`
`59`		`- .map_err(\|err\| io::Error::new(io::ErrorKind::Other, err))?;`
`60`		`- Ok(Some(value).into_iter())`
	`57`	`+ self.as_str().to_header_values()`
`61`	`58`	`}`
`62`	`59`	`}`
`63`	`60`
`64`	`61`	`impl ToHeaderValues for &String {`
`65`	`62`	`type Iter = option::IntoIter<HeaderValue>;`
`66`	`63`
`67`	`64`	`fn to_header_values(&self) -> crate::Result<Self::Iter> {`
`68`		`- let value = self`
`69`		`- .parse()`
`70`		`- .map_err(\|err\| io::Error::new(io::ErrorKind::Other, err))?;`
`71`		`- Ok(Some(value).into_iter())`
	`65`	`+ self.as_str().to_header_values()`
`72`	`66`	`}`
`73`	`67`	`}`
`74`	`68`