fix: address new clippy lints

- bool_assert_comparison
- needless_borrow
- clone_on_copy

Author: Fishrock123

src/cache/clear_site_data/mod.rs

@@ -280,7 +280,7 @@ mod test {
         entries.apply(&mut res);
 
         let entries = ClearSiteData::from_headers(res)?.unwrap();
-        assert_eq!(entries.wildcard(), true);
+        assert!(entries.wildcard());
         let mut entries = entries.iter();
         assert_eq!(entries.next().unwrap(), &ClearDirective::Cache);
         Ok(())
@@ -292,15 +292,15 @@ mod test {
         res.insert_header("clear-site-data", r#""cookies""#);
 
         let entries = ClearSiteData::from_headers(res)?.unwrap();
-        assert_eq!(entries.wildcard(), false);
+        assert!(!entries.wildcard());
         let mut entries = entries.iter();
         assert_eq!(entries.next().unwrap(), &ClearDirective::Cookies);
 
         let mut res = Response::new(200);
         res.insert_header("clear-site-data", r#""*""#);
 
         let entries = ClearSiteData::from_headers(res)?.unwrap();
-        assert_eq!(entries.wildcard(), true);
+        assert!(entries.wildcard());
         let mut entries = entries.iter();
         assert_eq!(entries.next(), None);
         Ok(())

src/conditional/if_match.rs

@@ -278,7 +278,7 @@ mod test {
         entries.apply(&mut res);
 
         let entries = IfMatch::from_headers(res)?.unwrap();
-        assert_eq!(entries.wildcard(), true);
+        assert!(entries.wildcard());
         let mut entries = entries.iter();
         assert_eq!(
             entries.next().unwrap(),

src/conditional/if_none_match.rs

@@ -284,7 +284,7 @@ mod test {
         entries.apply(&mut res);
 
         let entries = IfNoneMatch::from_headers(res)?.unwrap();
-        assert_eq!(entries.wildcard(), true);
+        assert!(entries.wildcard());
         let mut entries = entries.iter();
         assert_eq!(
             entries.next().unwrap(),

src/conditional/vary.rs

@@ -278,7 +278,7 @@ mod test {
         entries.apply(&mut res);
 
         let entries = Vary::from_headers(res)?.unwrap();
-        assert_eq!(entries.wildcard(), true);
+        assert!(entries.wildcard());
         let mut entries = entries.iter();
         assert_eq!(entries.next().unwrap(), "User-Agent");
         Ok(())

src/content/accept.rs

@@ -125,7 +125,7 @@ impl Accept {
 
         // Try and find the first encoding that matches.
         for accept in &self.entries {
-            if available.contains(&accept) {
+            if available.contains(accept) {
                 return Ok(accept.media_type.clone().into());
             }
         }

src/content/accept_encoding.rs

@@ -118,7 +118,7 @@ impl AcceptEncoding {
 
         // Try and find the first encoding that matches.
         for encoding in &self.entries {
-            if available.contains(&encoding) {
+            if available.contains(encoding) {
                 return Ok(encoding.into());
             }
         }
@@ -149,7 +149,7 @@ impl AcceptEncoding {
     pub fn value(&self) -> HeaderValue {
         let mut output = String::new();
         for (n, directive) in self.entries.iter().enumerate() {
-            let directive: HeaderValue = directive.clone().into();
+            let directive: HeaderValue = (*directive).into();
             match n {
                 0 => write!(output, "{}", directive).unwrap(),
                 _ => write!(output, ", {}", directive).unwrap(),

src/headers/header_name.rs

@@ -114,7 +114,7 @@ impl<'a> PartialEq<&'a str> for HeaderName {
 
 impl PartialEq<String> for HeaderName {
     fn eq(&self, other: &String) -> bool {
-        match HeaderName::from_str(&other) {
+        match HeaderName::from_str(other) {
             Err(_) => false,
             Ok(other) => self == &other,
         }

src/headers/header_values.rs

@@ -44,7 +44,7 @@ impl HeaderValues {
 
     /// An iterator visiting all header values in arbitrary order.
     pub fn iter(&self) -> Values<'_> {
-        Values::new_values(&self)
+        Values::new_values(self)
     }
 
     // /// An iterator visiting all header values in arbitrary order, with mutable

src/mime/mod.rs

@@ -43,7 +43,7 @@ impl Mime {
     /// Sniff the mime type from a byte slice.
     pub fn sniff(bytes: &[u8]) -> crate::Result<Self> {
         let info = Infer::new();
-        let mime = match info.get(&bytes) {
+        let mime = match info.get(bytes) {
             Some(info) => info.mime,
             None => crate::bail!("Could not sniff the mime type"),
         };

src/security/timing_allow_origin.rs

@@ -325,7 +325,7 @@ mod test {
         origins.apply(&mut headers);
 
         let origins = TimingAllowOrigin::from_headers(headers)?.unwrap();
-        assert_eq!(origins.wildcard(), true);
+        assert!(origins.wildcard());
         let origin = origins.iter().next().unwrap();
         assert_eq!(origin, &Url::parse("https://example.com")?);
         Ok(())