Skip to content

Commit d42b853

Browse files
committed
pass header names by ref
1 parent f3b8064 commit d42b853

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

src/headers/header_name.rs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,12 @@ impl FromStr for HeaderName {
6363
}
6464
}
6565

66+
impl From<&HeaderName> for HeaderName {
67+
fn from(value: &HeaderName) -> HeaderName {
68+
value.clone()
69+
}
70+
}
71+
6672
impl<'a> From<&'a str> for HeaderName {
6773
fn from(value: &'a str) -> Self {
6874
Self::from_str(value).unwrap()
@@ -134,4 +140,10 @@ mod tests {
134140
// Must validate regardless of casing.
135141
assert_eq!(static_header, &String::from("Hello"));
136142
}
143+
144+
#[test]
145+
fn pass_name_by_ref() {
146+
let mut res = crate::Response::new(200);
147+
res.insert_header(&crate::headers::HOST, "127.0.0.1");
148+
}
137149
}

src/headers/header_value.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
use std::convert::TryFrom;
12
use std::fmt::{self, Display};
23
use std::str::FromStr;
34

@@ -83,7 +84,7 @@ impl FromStr for HeaderValue {
8384
}
8485
}
8586

86-
impl<'a> std::convert::TryFrom<&'a str> for HeaderValue {
87+
impl<'a> TryFrom<&'a str> for HeaderValue {
8788
type Error = Error;
8889

8990
fn try_from(value: &'a str) -> Result<Self, Self::Error> {

0 commit comments

Comments
 (0)