fix clippy errors and warnings

This fixes a few clippy errors and warnings
with some noticable exceptions:

* new_without_default has been deactivated at crate level
since it does not seem to be considered mandatory (see 92#pullrequestreview-391768723)

* module_inception is allowed for private module headers::headers since
it would lead to too much refactoring. This is left as a TODO for the future.

Author: ririsoft

src/body.rs

@@ -439,7 +439,7 @@ impl<'a> From<&'a str> for Body {
 
 impl From<Vec<u8>> for Body {
     fn from(b: Vec<u8>) -> Self {
-        Self::from_bytes(b.to_owned())
+        Self::from_bytes(b)
     }
 }
 

src/headers/header_values.rs

@@ -113,13 +113,13 @@ impl<'a> PartialEq<[&'a str]> for HeaderValues {
 
 impl PartialEq<String> for HeaderValues {
     fn eq(&self, other: &String) -> bool {
-        self.inner.len() == 1 && &self.inner[0] == other
+        self.inner.len() == 1 && self.inner[0] == *other
     }
 }
 
 impl<'a> PartialEq<&String> for HeaderValues {
     fn eq(&self, other: &&String) -> bool {
-        self.inner.len() == 1 && &&self.inner[0] == other
+        self.inner.len() == 1 && self.inner[0] == **other
     }
 }
 

src/headers/mod.rs

@@ -4,6 +4,7 @@ mod constants;
 mod header_name;
 mod header_value;
 mod header_values;
+#[allow(clippy::module_inception)]
 mod headers;
 mod into_iter;
 mod iter;

src/lib.rs

@@ -95,6 +95,7 @@
 
 #![deny(missing_debug_implementations, nonstandard_style)]
 #![warn(missing_docs, unreachable_pub)]
+#![allow(clippy::new_without_default)]
 #![cfg_attr(test, deny(warnings))]
 #![cfg_attr(feature = "docs", feature(doc_cfg))]
 #![doc(html_favicon_url = "https://yoshuawuyts.com/assets/http-rs/favicon.ico")]

src/request.rs

@@ -115,16 +115,16 @@ impl Request {
         self.forwarded_header_part("host")
             .or_else(|| {
                 self.header("X-Forwarded-Host")
-                    .and_then(|h| h.as_str().split(",").next())
+                    .and_then(|h| h.as_str().split(',').next())
             })
             .or_else(|| self.header(&headers::HOST).map(|h| h.as_str()))
             .or_else(|| self.url().host_str())
     }
 
     fn forwarded_header_part(&self, part: &str) -> Option<&str> {
         self.header("Forwarded").and_then(|header| {
-            header.as_str().split(";").find_map(|key_equals_value| {
-                let parts = key_equals_value.split("=").collect::<Vec<_>>();
+            header.as_str().split(';').find_map(|key_equals_value| {
+                let parts = key_equals_value.split('=').collect::<Vec<_>>();
                 if parts.len() == 2 && parts[0].eq_ignore_ascii_case(part) {
                     Some(parts[1])
                 } else {
@@ -137,7 +137,7 @@ impl Request {
     fn forwarded_for(&self) -> Option<&str> {
         self.forwarded_header_part("for").or_else(|| {
             self.header("X-Forwarded-For")
-                .and_then(|header| header.as_str().split(",").next())
+                .and_then(|header| header.as_str().split(',').next())
         })
     }
 
@@ -871,10 +871,10 @@ impl Clone for Request {
     /// extensions.
     fn clone(&self) -> Self {
         Request {
-            method: self.method.clone(),
+            method: self.method,
             url: self.url.clone(),
             headers: self.headers.clone(),
-            version: self.version.clone(),
+            version: self.version,
             trailers_sender: None,
             trailers_receiver: None,
             body: Body::empty(),
@@ -1145,8 +1145,8 @@ mod tests {
             set_x_forwarded_for(&mut request, "forwarded-for-client.com");
             request.peer_addr = Some("127.0.0.1:8000".into());
 
-            assert_eq!(request.forwarded_for(), Some("forwarded.com".into()));
-            assert_eq!(request.remote(), Some("forwarded.com".into()));
+            assert_eq!(request.forwarded_for(), Some("forwarded.com"));
+            assert_eq!(request.remote(), Some("forwarded.com"));
         }
 
         #[test]
@@ -1155,7 +1155,7 @@ mod tests {
             request.peer_addr = Some("127.0.0.1:8000".into());
 
             assert_eq!(request.forwarded_for(), None);
-            assert_eq!(request.remote(), Some("127.0.0.1:8000".into()));
+            assert_eq!(request.remote(), Some("127.0.0.1:8000"));
         }
 
         #[test]

src/response.rs

@@ -666,9 +666,9 @@ impl Clone for Response {
     /// - Any attached error is not cloned.
     fn clone(&self) -> Self {
         Self {
-            status: self.status.clone(),
+            status: self.status,
             headers: self.headers.clone(),
-            version: self.version.clone(),
+            version: self.version,
             trailers_sender: self.trailers_sender.clone(),
             trailers_receiver: self.trailers_receiver.clone(),
             has_trailers: false,

src/security/csp.rs

@@ -354,6 +354,6 @@ impl ContentSecurityPolicy {
         } else {
             "Content-Security-Policy"
         };
-        headers.as_mut().insert(name, self.value().to_owned());
+        headers.as_mut().insert(name, self.value());
     }
 }

tests/error.rs

@@ -13,8 +13,7 @@ fn can_be_boxed() {
 #[test]
 fn internal_server_error_by_default() {
     fn run() -> http_types::Result<()> {
-        Err(io::Error::new(io::ErrorKind::Other, "Oh no"))?;
-        Ok(())
+        Err(io::Error::new(io::ErrorKind::Other, "Oh no").into())
     }
     let err = run().unwrap_err();
     assert_eq!(err.status(), 500);
@@ -23,7 +22,7 @@ fn internal_server_error_by_default() {
 #[test]
 fn ensure() {
     fn inner() -> http_types::Result<()> {
-        ensure!(1 == 1, "Oh yes");
+        ensure!(true, "Oh yes");
         bail!("Oh no!");
     }
     let res = inner();