Skip to content

Fix all failing clippy lints for backports branch #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 10, 2022
Merged

Fix all failing clippy lints for backports branch #399

merged 4 commits into from
May 10, 2022

Conversation

arlyon
Copy link

@arlyon arlyon commented Mar 29, 2022

Hi

I am interested in getting #396 merged and noticed it is blocked due to failing clippy lints on this branch. I have simply run through and fixed them.

@arlyon arlyon changed the title Fix all failing clippy lints for CI Fix all failing clippy lints for backports branch Mar 29, 2022
@arlyon arlyon mentioned this pull request Mar 29, 2022
Open
@arlyon
Copy link
Author

arlyon commented Mar 29, 2022

There seems to be a test that is (consistently) broken on this branch as well, having failed both CI runs: https://github.com/http-rs/http-types/runs/5734932654?check_suite_focus=true

@arlyon
Copy link
Author

arlyon commented Mar 29, 2022 •
edited
Loading

More investigation: tests pass on rust version 1.59.0, fail on version 1.61.0-nightly. Seems like some float rounding issues.

failures:

---- trace::server_timing::parse::test::decode_headers stdout ----
thread 'trace::server_timing::parse::test::decode_headers' panicked at 'assertion failed: `(left == right)`
  left: `Some(52.999999ms)`,
 right: `Some(53ms)`', src/trace/server_timing/parse.rs:162:9


failures:
    trace::server_timing::parse::test::decode_headers

test result: FAILED. 180 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

error: test failed, to rerun pass '--lib'

@Fishrock123 Fishrock123 merged commit 7236637 into http-rs:v2.x.x-backports May 10, 2022
@Fishrock123
Copy link
Member

In the future, you may want to run cargo clippy --workspace --all-targets to catch everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arlyon @Fishrock123 @yoshuawuyts