ci, src: run clippy on nightly, apply fixes

The rc_buffer thing is similar to http-rs/surf#242

Author: Fishrock123

.github/workflows/ci.yaml

@@ -78,7 +78,7 @@ jobs:
 
     - uses: actions-rs/toolchain@v1
       with:
-        toolchain: stable
+        toolchain: nightly
         override: true
 
     - name: setup

src/route.rs

@@ -43,7 +43,7 @@ impl<'a, State: Clone + Send + Sync + 'static> Route<'a, State> {
         let mut p = self.path.clone();
 
         if !p.ends_with('/') && !path.starts_with('/') {
-            p.push_str("/");
+            p.push('/');
         }
 
         if path != "/" {
@@ -289,7 +289,7 @@ where
             route_params,
         } = req;
 
-        let rest = crate::request::rest(&route_params).unwrap_or_else(|| "");
+        let rest = crate::request::rest(&route_params).unwrap_or("");
         req.url_mut().set_path(&rest);
 
         self.0

src/server.rs

@@ -28,6 +28,14 @@ use crate::{Endpoint, Request, Route};
 pub struct Server<State> {
     router: Arc<Router<State>>,
     state: State,
+    /// Holds the middleware stack.
+    ///
+    /// Note(Fishrock123): We do actually want this structure.
+    /// The outer Arc allows us to clone in .respond() without cloning the array.
+    /// The Vec allows us to add middleware at runtime.
+    /// The inner Arc-s allow MiddlewareEndpoint-s to be cloned internally.
+    /// We don't use a Mutex around the Vec here because adding a middleware during execution should be an error.
+    #[allow(clippy::rc_buffer)]
     middleware: Arc<Vec<Arc<dyn Middleware<State>>>>,
 }