Remove Result from Request::cookie

Author: yoshuawuyts

src/middleware/cookies.rs

@@ -13,16 +13,14 @@ use std::sync::{Arc, RwLock};
 ///
 /// # Examples
 ///
-/// ```rust
-///
+/// ```
 /// let mut app = tide::Server::new();
-/// app.at("/get").get(|cx: tide::Request<()>| async move { cx.cookie("testCookie").unwrap().unwrap().value().to_string() });
+/// app.at("/get").get(|cx: tide::Request<()>| async move { cx.cookie("testCookie").unwrap().value().to_string() });
 /// app.at("/set").get(|_| async {
 ///     let mut res = tide::Response::new(200);
 ///     res.set_cookie(cookie::Cookie::new("testCookie", "NewCookieValue"));
 ///     res
 /// });
-///
 /// ```
 #[derive(Debug, Clone, Default)]
 pub(crate) struct CookiesMiddleware;

src/request.rs

@@ -10,7 +10,6 @@ use async_std::task::{Context, Poll};
 use std::pin::Pin;
 use std::{str::FromStr, sync::Arc};
 
-use crate::error::Error;
 use crate::middleware::cookies::CookieData;
 
 pin_project_lite::pin_project! {
@@ -299,13 +298,13 @@ impl<State> Request<State> {
     }
 
     /// returns a `Cookie` by name of the cookie.
-    pub fn cookie(&self, name: &str) -> Result<Option<Cookie<'static>>, Error> {
+    pub fn cookie(&self, name: &str) -> Option<Cookie<'static>> {
         let cookie_data = self
             .local::<CookieData>()
             .expect("should always be set by the cookies middleware");
 
         let locked_jar = cookie_data.content.read().unwrap();
-        Ok(locked_jar.get(name).cloned())
+        locked_jar.get(name).cloned()
     }
 }
 

tests/cookies.rs

@@ -9,7 +9,7 @@ use tide::{Request, Response, Server};
 static COOKIE_NAME: &str = "testCookie";
 
 async fn retrieve_cookie(cx: Request<()>) -> String {
-    cx.cookie(COOKIE_NAME).unwrap().unwrap().value().to_string()
+    cx.cookie(COOKIE_NAME).unwrap().value().to_string()
 }
 
 async fn set_cookie(_req: Request<()>) -> Response {