rename insert_cookie to append_cookie

Author: yoshuawuyts

examples/cookies.rs

@@ -8,9 +8,9 @@ async fn retrieve_cookie(cx: Request<()>) -> tide::Result<String> {
     Ok(format!("hello cookies: {:?}", cx.cookie("hello").unwrap()))
 }
 
-async fn insert_cookie(_req: Request<()>) -> tide::Result {
+async fn append_cookie(_req: Request<()>) -> tide::Result {
     let mut res = tide::Response::new(StatusCode::Ok);
-    res.insert_cookie(Cookie::new("hello", "world"));
+    res.append_cookie(Cookie::new("hello", "world"));
     Ok(res)
 }
 
@@ -25,7 +25,7 @@ fn main() -> Result<(), std::io::Error> {
         let mut app = tide::new();
 
         app.at("/").get(retrieve_cookie);
-        app.at("/set").get(insert_cookie);
+        app.at("/set").get(append_cookie);
         app.at("/remove").get(remove_cookie);
         app.listen("127.0.0.1:8080").await?;
 

src/cookies/middleware.rs

@@ -18,7 +18,7 @@ use std::sync::{Arc, RwLock};
 /// app.at("/get").get(|cx: Request<()>| async move { Ok(cx.cookie("testCookie").unwrap().value().to_string()) });
 /// app.at("/set").get(|_| async {
 ///     let mut res = Response::new(StatusCode::Ok);
-///     res.insert_cookie(Cookie::new("testCookie", "NewCookieValue"));
+///     res.append_cookie(Cookie::new("testCookie", "NewCookieValue"));
 ///     Ok(res)
 /// });
 /// ```

src/response.rs

@@ -176,7 +176,7 @@ impl Response {
     }
 
     /// Insert cookie in the cookie jar.
-    pub fn insert_cookie(&mut self, cookie: Cookie<'static>) {
+    pub fn append_cookie(&mut self, cookie: Cookie<'static>) {
         self.cookie_events.push(CookieEvent::Added(cookie));
     }
 

tests/cookies.rs

@@ -14,9 +14,9 @@ async fn retrieve_cookie(cx: Request<()>) -> tide::Result<String> {
     ))
 }
 
-async fn insert_cookie(_req: Request<()>) -> tide::Result {
+async fn append_cookie(_req: Request<()>) -> tide::Result {
     let mut res = Response::new(StatusCode::Ok);
-    res.insert_cookie(Cookie::new(COOKIE_NAME, "NewCookieValue"));
+    res.append_cookie(Cookie::new(COOKIE_NAME, "NewCookieValue"));
     Ok(res)
 }
 
@@ -28,16 +28,16 @@ async fn remove_cookie(_req: Request<()>) -> tide::Result {
 
 async fn set_multiple_cookie(_req: Request<()>) -> tide::Result {
     let mut res = Response::new(StatusCode::Ok);
-    res.insert_cookie(Cookie::new("C1", "V1"));
-    res.insert_cookie(Cookie::new("C2", "V2"));
+    res.append_cookie(Cookie::new("C1", "V1"));
+    res.append_cookie(Cookie::new("C2", "V2"));
     Ok(res)
 }
 
 fn app() -> crate::Server<()> {
     let mut app = tide::new();
 
     app.at("/get").get(retrieve_cookie);
-    app.at("/set").get(insert_cookie);
+    app.at("/set").get(append_cookie);
     app.at("/remove").get(remove_cookie);
     app.at("/multi").get(set_multiple_cookie);
     app
@@ -75,7 +75,7 @@ async fn successfully_retrieve_request_cookie() {
 }
 
 #[async_std::test]
-async fn successfully_insert_cookie() {
+async fn successfully_append_cookie() {
     let res = make_request("/set").await;
     assert_eq!(res.status(), StatusCode::Ok);
     assert_eq!(res[SET_COOKIE], "testCookie=NewCookieValue");