Commit e615178
authored
Make SSL hostname verification default to on (#636)
Following up on this comment:
#634 (review)
The previous logic skipped hostname verification entirely if the
`verify_hostname` method is not defined for `OpenSSL::SSL::SSLContext`,
which is currently the case for JRuby.
This commit changes the logic so if that method is undefined, hostname
verification is still performed. Otherwise, hostname verification would
always be skipped on Rubies which don't define a `verify_hostname`
method.
Note that this was *just* introduced in #634 which was merged 10 hours
ago, so I think this was caught quickly enough simply correcting it
suffices and there isn't additional security-related followup here
(e.g. CVE)1 parent 9bb0136 commit e615178
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
0 commit comments