Add new PHP versions to build workflow (#1)

devanych · web-flow · commit ab4759c2dcb7 · 2023-03-27T18:58:51.000+03:00
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -1,6 +1,21 @@
 on:
-  - pull_request
-  - push
+  pull_request:
+    paths-ignore:
+      - 'docs/**'
+      - 'README.md'
+      - 'CHANGELOG.md'
+      - '.gitignore'
+      - '.gitattributes'
+      - 'psalm.xml.dist'
+
+  push:
+    paths-ignore:
+      - 'docs/**'
+      - 'README.md'
+      - 'CHANGELOG.md'
+      - '.gitignore'
+      - '.gitattributes'
+      - 'psalm.xml.dist'
 
 name: build
 
@@ -22,40 +37,42 @@ jobs:
         php:
           - "7.4"
           - "8.0"
+          - "8.1"
+          - "8.2"
 
     steps:
-      - name: Checkout
-        uses: actions/checkout@v2
+      - name: Checkout.
+        uses: actions/checkout@v3
 
-      - name: Install PHP
+      - name: Install PHP with extensions.
         uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php }}
           ini-values: date.timezone='UTC'
           tools: composer:v2
           coverage: pcov
 
-      - name: Determine composer cache directory on Linux
+      - name: Determine composer cache directory on Linux.
         if: matrix.os == 'ubuntu-latest'
         run: echo "COMPOSER_CACHE_DIR=$(composer config cache-dir)" >> $GITHUB_ENV
 
-      - name: Determine composer cache directory on Windows
+      - name: Determine composer cache directory on Windows.
         if: matrix.os == 'windows-latest'
         run: echo "COMPOSER_CACHE_DIR=~\AppData\Local\Composer" | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
 
-      - name: Cache dependencies installed with composer
-        uses: actions/cache@v2
+      - name: Cache dependencies installed with composer.
+        uses: actions/cache@v3
         with:
           path: ${{ env.COMPOSER_CACHE_DIR }}
           key: php${{ matrix.php }}-composer-${{ hashFiles('**/composer.json') }}
           restore-keys: |
             php${{ matrix.php }}-composer-
 
-      - name: Update composer
+      - name: Update composer.
         run: composer self-update
 
-      - name: Install dependencies with composer
+      - name: Install dependencies with composer.
         run: composer update --prefer-dist --no-interaction --no-progress --optimize-autoloader --ansi
 
-      - name: Run tests with phpunit
+      - name: Run tests with phpunit.
         run: vendor/bin/phpunit --colors=always
diff --git a/.github/workflows/static.yml b/.github/workflows/static.yml
@@ -1,6 +1,21 @@
 on:
-  - pull_request
-  - push
+  pull_request:
+    paths-ignore:
+      - 'docs/**'
+      - 'README.md'
+      - 'CHANGELOG.md'
+      - '.gitignore'
+      - '.gitattributes'
+      - 'phpunit.xml.dist'
+
+  push:
+    paths-ignore:
+      - 'docs/**'
+      - 'README.md'
+      - 'CHANGELOG.md'
+      - '.gitignore'
+      - '.gitattributes'
+      - 'phpunit.xml.dist'
 
 name: static
 
@@ -18,37 +33,39 @@ jobs:
         php:
           - "7.4"
           - "8.0"
+          - "8.1"
+          - "8.2"
 
     steps:
-      - name: Checkout
-        uses: actions/checkout@v2
+      - name: Checkout.
+        uses: actions/checkout@v3
 
-      - name: Install PHP
+      - name: Install PHP with extensions.
         uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php }}
           ini-values: memory_limit=-1
           tools: composer:v2
 
-      - name: Determine composer cache directory
+      - name: Determine composer cache directory.
         run: echo "COMPOSER_CACHE_DIR=$(composer config cache-dir)" >> $GITHUB_ENV
 
-      - name: Cache dependencies installed with composer
-        uses: actions/cache@v2
+      - name: Cache dependencies installed with composer.
+        uses: actions/cache@v3
         with:
           path: ${{ env.COMPOSER_CACHE_DIR }}
           key: php${{ matrix.php }}-composer-${{ hashFiles('**/composer.json') }}
           restore-keys: |
             php${{ matrix.php }}-composer-
 
-      - name: Update composer
+      - name: Update composer.
         run: composer self-update
 
-      - name: Install dependencies with composer
+      - name: Install dependencies with composer.
         run: composer update --prefer-dist --no-interaction --no-progress --optimize-autoloader --ansi
 
-      - name: PHPCS check
+      - name: PHPCS check.
         run: vendor/bin/phpcs
 
-      - name: Psalm static analysis
+      - name: Psalm static analysis.
         run: vendor/bin/psalm --no-progress
diff --git a/.gitignore b/.gitignore
@@ -1,4 +1,5 @@
 .phpunit.result.cache
 composer.lock
 phpunit.xml
+psalm.xml
 vendor
diff --git a/composer.json b/composer.json
@@ -27,8 +27,8 @@
     "require-dev": {
         "httpsoft/http-message": "^1.0",
         "phpunit/phpunit": "^9.5",
-        "squizlabs/php_codesniffer": "^3.6",
-        "vimeo/psalm": "^4.9"
+        "squizlabs/php_codesniffer": "^3.7",
+        "vimeo/psalm": "^4.9|^5.2"
     },
     "provide": {
         "psr/http-message-implementation": "1.0",
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -1,16 +1,17 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="UTF-8"?>
 <phpunit
-    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-    xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/8.5/phpunit.xsd"
-    bootstrap="./vendor/autoload.php"
-    executionOrder="depends,defects"
+    bootstrap="vendor/autoload.php"
+    executionOrder="random"
     beStrictAboutCoversAnnotation="true"
     beStrictAboutOutputDuringTests="true"
     beStrictAboutTodoAnnotatedTests="true"
     convertWarningsToExceptions="true"
     convertNoticesToExceptions="true"
     convertErrorsToExceptions="true"
+    resolveDependencies="true"
     stopOnFailure="false"
+    failOnWarning="true"
+    failOnRisky="true"
     verbose="true"
     colors="true"
 >
@@ -24,9 +25,9 @@
         </testsuite>
     </testsuites>
 
-    <filter>
-        <whitelist>
-            <directory suffix=".php">./src/</directory>
-        </whitelist>
-    </filter>
+    <coverage processUncoveredFiles="true">
+        <include>
+            <directory suffix=".php">./src</directory>
+        </include>
+    </coverage>
 </phpunit>
diff --git a/psalm.xml.dist b/psalm.xml.dist
@@ -1,11 +1,15 @@
 <?xml version="1.0"?>
 <psalm
     errorLevel="1"
+    findUnusedPsalmSuppress="true"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xmlns="https://getpsalm.org/schema/config"
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
 >
     <projectFiles>
-        <directory name="src" />
+        <directory name="src"/>
+        <ignoreFiles>
+            <directory name="vendor"/>
+        </ignoreFiles>
     </projectFiles>
 </psalm>
diff --git a/src/Cookie.php b/src/Cookie.php
@@ -448,7 +448,7 @@ private function setSameSite(?string $sameSite): void
             throw new InvalidArgumentException(sprintf(
                 'The sameSite attribute `%s` is not valid; must be one of (%s).',
                 $sameSite,
-                implode(', ', array_map(fn($item) => "\"{$item}\"", $sameSiteValues))
+                implode(', ', array_map(static fn($item) => "\"$item\"", $sameSiteValues)),
             ));
         }
 
diff --git a/src/CookieCreator.php b/src/CookieCreator.php
@@ -42,7 +42,7 @@ public static function create(
         ?string $path = '/',
         ?bool $secure = true,
         ?bool $httpOnly = true,
-        ?string $sameSite = Cookie::SAME_SITE_LAX
+        ?string $sameSite = CookieInterface::SAME_SITE_LAX
     ): CookieInterface {
         return new Cookie($name, $value, $expire, $domain, $path, $secure, $httpOnly, $sameSite);
     }
diff --git a/src/CookieManagerInterface.php b/src/CookieManagerInterface.php
@@ -8,6 +8,9 @@
 use IteratorAggregate;
 use Psr\Http\Message\ResponseInterface;
 
+/**
+ * @psalm-suppress MissingTemplateParam
+ */
 interface CookieManagerInterface extends Countable, IteratorAggregate
 {
     /**

Original file line number	Diff line number	Diff line change
`@@ -448,7 +448,7 @@ private function setSameSite(?string $sameSite): void`
`448`	`448`	`throw new InvalidArgumentException(sprintf(`
`449`	`449`	'The sameSite attribute `%s` is not valid; must be one of (%s).',
`450`	`450`	`$sameSite,`
`451`		`- implode(', ', array_map(fn($item) => "\"{$item}\"", $sameSiteValues))`
	`451`	`+ implode(', ', array_map(static fn($item) => "\"$item\"", $sameSiteValues)),`
`452`	`452`	`));`
`453`	`453`	`}`
`454`	`454`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public static function create(`
`42`	`42`	`?string $path = '/',`
`43`	`43`	`?bool $secure = true,`
`44`	`44`	`?bool $httpOnly = true,`
`45`		`- ?string $sameSite = Cookie::SAME_SITE_LAX`
	`45`	`+ ?string $sameSite = CookieInterface::SAME_SITE_LAX`
`46`	`46`	`): CookieInterface {`
`47`	`47`	`return new Cookie($name, $value, $expire, $domain, $path, $secure, $httpOnly, $sameSite);`
`48`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,9 @@`
`8`	`8`	`use IteratorAggregate;`
`9`	`9`	`use Psr\Http\Message\ResponseInterface;`
`10`	`10`
	`11`	`+/**`
	`12`	`+ * @psalm-suppress MissingTemplateParam`
	`13`	`+ */`
`11`	`14`	`interface CookieManagerInterface extends Countable, IteratorAggregate`
`12`	`15`	`{`
`13`	`16`	`/**`