Add more test cases for code coverage

Author: devanych

tests/ErrorHandlerMiddlewareTest.php

@@ -9,6 +9,7 @@
 use HttpSoft\ServerRequest\ServerRequestCreator;
 use HttpSoft\Response\ResponseStatusCodeInterface;
 use HttpSoft\Tests\ErrorHandler\TestAsset\ErrorRequestHandler;
+use HttpSoft\Tests\ErrorHandler\TestAsset\ErrorResponseGenerator;
 use HttpSoft\Tests\ErrorHandler\TestAsset\ThrowableRequestHandler;
 use HttpSoft\Tests\ErrorHandler\TestAsset\FirstErrorListener;
 use HttpSoft\Tests\ErrorHandler\TestAsset\RequestHandler;
@@ -173,6 +174,32 @@ public function testWithErrorRequestHandlerAndWithAdditionOfListeners(): void
         $this->assertTrue($secondListener->triggered());
     }
 
+    public function testWithDefaultErrorCodeForNotValidResponseStatusCodeAndErrorCode(): void
+    {
+        $errorHandler = new ErrorHandlerMiddleware(new ErrorResponseGenerator(self::STATUS_FOUND));
+        $response = $errorHandler->process(
+            $this->request,
+            $this->createThrowableRequestHandler(self::STATUS_MOVED_PERMANENTLY)
+        );
+
+        $this->assertInstanceOf(ResponseInterface::class, $response);
+        $this->assertSame(self::STATUS_INTERNAL_SERVER_ERROR, $response->getStatusCode());
+        $this->assertSame(self::PHRASES[self::STATUS_INTERNAL_SERVER_ERROR], $response->getReasonPhrase());
+    }
+
+    public function testWithErrorCodeForNotValidResponseStatusCode(): void
+    {
+        $errorHandler = new ErrorHandlerMiddleware(new ErrorResponseGenerator(self::STATUS_FOUND));
+        $response = $errorHandler->process(
+            $this->request,
+            $this->createThrowableRequestHandler(self::STATUS_NOT_FOUND)
+        );
+
+        $this->assertInstanceOf(ResponseInterface::class, $response);
+        $this->assertSame(self::STATUS_NOT_FOUND, $response->getStatusCode());
+        $this->assertSame(self::PHRASES[self::STATUS_NOT_FOUND], $response->getReasonPhrase());
+    }
+
     /**
      * @param int|null $code
      * @return RequestHandler

tests/ErrorHandlerTest.php

@@ -9,6 +9,7 @@
 use HttpSoft\ServerRequest\ServerRequestCreator;
 use HttpSoft\Response\ResponseStatusCodeInterface;
 use HttpSoft\Tests\ErrorHandler\TestAsset\ErrorRequestHandler;
+use HttpSoft\Tests\ErrorHandler\TestAsset\ErrorResponseGenerator;
 use HttpSoft\Tests\ErrorHandler\TestAsset\ThrowableRequestHandler;
 use HttpSoft\Tests\ErrorHandler\TestAsset\FirstErrorListener;
 use HttpSoft\Tests\ErrorHandler\TestAsset\RequestHandler;
@@ -166,6 +167,30 @@ public function testWithErrorRequestHandlerAndWithAdditionOfListeners(): void
         $this->assertTrue($secondListener->triggered());
     }
 
+    public function testWithDefaultErrorCodeForNotValidResponseStatusCodeAndErrorCode(): void
+    {
+        $errorHandler = new ErrorHandler(
+            new ThrowableRequestHandler(self::STATUS_MOVED_PERMANENTLY),
+            new ErrorResponseGenerator(self::STATUS_FOUND),
+        );
+        $response = $errorHandler->handle($this->request);
+        $this->assertInstanceOf(ResponseInterface::class, $response);
+        $this->assertSame(self::STATUS_INTERNAL_SERVER_ERROR, $response->getStatusCode());
+        $this->assertSame(self::PHRASES[self::STATUS_INTERNAL_SERVER_ERROR], $response->getReasonPhrase());
+    }
+
+    public function testWithErrorCodeForNotValidResponseStatusCode(): void
+    {
+        $errorHandler = new ErrorHandler(
+            new ThrowableRequestHandler(self::STATUS_NOT_FOUND),
+            new ErrorResponseGenerator(self::STATUS_FOUND),
+        );
+        $response = $errorHandler->handle($this->request);
+        $this->assertInstanceOf(ResponseInterface::class, $response);
+        $this->assertSame(self::STATUS_NOT_FOUND, $response->getStatusCode());
+        $this->assertSame(self::PHRASES[self::STATUS_NOT_FOUND], $response->getReasonPhrase());
+    }
+
     /**
      * @param int|null $code
      * @return ErrorHandler

tests/TestAsset/ErrorResponseGenerator.php

@@ -0,0 +1,32 @@
+<?php
+
+declare(strict_types=1);
+
+namespace HttpSoft\Tests\ErrorHandler\TestAsset;
+
+use HttpSoft\ErrorHandler\ErrorResponseGeneratorInterface;
+use HttpSoft\Message\Response;
+use Psr\Http\Message\ResponseInterface;
+use Psr\Http\Message\ServerRequestInterface;
+use Throwable;
+
+class ErrorResponseGenerator implements ErrorResponseGeneratorInterface
+{
+    /**
+     * @var int
+     */
+    private int $code;
+
+    /**
+     * @param int $code
+     */
+    public function __construct(int $code)
+    {
+        $this->code = $code;
+    }
+
+    public function generate(Throwable $error, ServerRequestInterface $request): ResponseInterface
+    {
+        return new Response($this->code);
+    }
+}