Change the order of arguments headers and body

Author: devanych

README.md

@@ -40,7 +40,7 @@ $response->getHeaders(); // []
 $response->getProtocolVersion(); // '1.1'
 
 // Create with the passed parameters
-$response = new Response(404, '', 'php://memory', ['Content-Language' => 'en'], '2');
+$response = new Response(404, ['Content-Language' => 'en'], 'php://memory', '2');
 $response->getStatusCode(); // 404
 $response->getReasonPhrase(); // 'Not Found'
 $response->getBody()->getContents(); // ''

src/EmptyResponse.php

@@ -23,6 +23,6 @@ public function __construct(
         string $protocol = '1.1',
         string $reasonPhrase = ''
     ) {
-        $this->init($code, $reasonPhrase, StreamFactory::create('php://temp', 'r'), $headers, $protocol);
+        $this->init($code, $reasonPhrase, $headers, StreamFactory::create('php://temp', 'r'), $protocol);
     }
 }

src/HtmlResponse.php

@@ -25,7 +25,7 @@ public function __construct(
         string $protocol = '1.1',
         string $reasonPhrase = ''
     ) {
-        $this->init($code, $reasonPhrase, StreamFactory::createFromContent($html), $headers, $protocol);
+        $this->init($code, $reasonPhrase, $headers, StreamFactory::createFromContent($html), $protocol);
         $this->setContentTypeHeaderIfNotExists('text/html; charset=UTF-8');
     }
 }

src/JsonResponse.php

@@ -55,7 +55,7 @@ public function __construct(
         int $encodingOptions = self::DEFAULT_OPTIONS
     ) {
         $json = $this->encode($data, $encodingOptions);
-        $this->init($code, $reasonPhrase, StreamFactory::createFromContent($json), $headers, $protocol);
+        $this->init($code, $reasonPhrase, $headers, StreamFactory::createFromContent($json), $protocol);
         $this->setContentTypeHeaderIfNotExists('application/json; charset=UTF-8');
     }
 

src/RedirectResponse.php

@@ -25,6 +25,6 @@ public function __construct(
         string $reasonPhrase = ''
     ) {
         $headers['Location'] = $uri;
-        $this->init($code, $reasonPhrase, 'php://temp', $headers, $protocol);
+        $this->init($code, $reasonPhrase, $headers, 'php://temp', $protocol);
     }
 }

src/Response.php

@@ -13,18 +13,18 @@ final class Response implements ResponseInterface, ResponseStatusCodeInterface
 
     /**
      * @param int $statusCode
-     * @param string $reasonPhrase
-     * @param StreamInterface|string|resource $body
      * @param array $headers
+     * @param StreamInterface|string|resource $body
      * @param string $protocol
+     * @param string $reasonPhrase
      */
     public function __construct(
         int $statusCode = self::STATUS_OK,
-        string $reasonPhrase = '',
-        $body = 'php://temp',
         array $headers = [],
-        string $protocol = '1.1'
+        $body = 'php://temp',
+        string $protocol = '1.1',
+        string $reasonPhrase = ''
     ) {
-        $this->init($statusCode, $reasonPhrase, $body, $headers, $protocol);
+        $this->init($statusCode, $reasonPhrase, $headers, $body, $protocol);
     }
 }

src/ResponseFactory.php

@@ -12,27 +12,27 @@ final class ResponseFactory implements ResponseFactoryInterface
 {
     /**
      * @param int $statusCode
-     * @param string $reasonPhrase
-     * @param StreamInterface|string|resource $body
      * @param array $headers
+     * @param StreamInterface|string|resource $body
      * @param string $protocol
+     * @param string $reasonPhrase
      * @return ResponseInterface
      */
     public static function create(
         int $statusCode = Response::STATUS_OK,
-        string $reasonPhrase = '',
-        $body = 'php://temp',
         array $headers = [],
-        string $protocol = '1.1'
+        $body = 'php://temp',
+        string $protocol = '1.1',
+        string $reasonPhrase = ''
     ): ResponseInterface {
-        return new Response($statusCode, $reasonPhrase, $body, $headers, $protocol);
+        return new Response($statusCode, $headers, $body, $protocol, $reasonPhrase);
     }
 
     /**
      * {@inheritDoc}
      */
     public function createResponse(int $statusCode = Response::STATUS_OK, string $reasonPhrase = ''): ResponseInterface
     {
-        return new Response($statusCode, $reasonPhrase);
+        return new Response($statusCode, [], 'php://temp', '1.1', $reasonPhrase);
     }
 }

src/ResponseTrait.php

@@ -123,13 +123,13 @@ public function getReasonPhrase(): string
     private function init(
         int $statusCode = ResponseStatusCodeInterface::STATUS_OK,
         string $reasonPhrase = '',
-        $body = 'php://temp',
         array $headers = [],
+        $body = 'php://temp',
         string $protocol = '1.1'
     ): void {
         $this->setStatus($statusCode, $reasonPhrase);
-        $this->stream = StreamFactory::create($body);
         $this->registerHeaders($headers);
+        $this->stream = StreamFactory::create($body);
         $this->registerProtocolVersion($protocol);
     }
 

src/TextResponse.php

@@ -25,7 +25,7 @@ public function __construct(
         string $protocol = '1.1',
         string $reasonPhrase = ''
     ) {
-        $this->init($code, $reasonPhrase, StreamFactory::createFromContent($text), $headers, $protocol);
+        $this->init($code, $reasonPhrase, $headers, StreamFactory::createFromContent($text), $protocol);
         $this->setContentTypeHeaderIfNotExists('text/plain; charset=UTF-8');
     }
 }

src/XmlResponse.php

@@ -25,7 +25,7 @@ public function __construct(
         string $protocol = '1.1',
         string $reasonPhrase = ''
     ) {
-        $this->init($code, $reasonPhrase, StreamFactory::createFromContent($xml), $headers, $protocol);
+        $this->init($code, $reasonPhrase, $headers, StreamFactory::createFromContent($xml), $protocol);
         $this->setContentTypeHeaderIfNotExists('application/xml; charset=UTF-8');
     }
 }