Fix body-writer exception causes hang #532
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrstux
force-pushed
the
fix-body-writer-exception-handling
branch
2 times, most recently
from
8c9387b to
ab8b51a
Compare
A sufficiently complex body-writer may not be able to complete writing the body, and the only practical approach is to throw an exception. Exceptions are normally thrown from body-writers when the socket is closed by the remote peer. If a Raw response body-writer throws an exception before completing the body the http session will be left out of sync and will hang indefinitely waiting to read the next request. The fix results in the socket being closed and not attempting to read the next request when an error occurs. If a content-length is provided then the network error can be detected by the remote peer, otherwise a truncated body is returned to the client.
mrstux
force-pushed
the
fix-body-writer-exception-handling
branch
from
ab8b51a to
9ad8a89
Compare
|
branched from 1.5.0. Simply merging stable will resolve above conflicts. |
mrstux
force-pushed
the
fix-body-writer-exception-handling
branch
2 times, most recently
from
21ebb16 to
9ad8a89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A sufficiently complex body-writer may not be able to complete writing the body, and the only practical approach is to throw an exception.
Exceptions are normally thrown from body-writers when the socket is closed by the remote peer.
If a Raw response body-writer throws an exception before completing the body the http session will be left out of sync and will hang indefinitely waiting to read the next request. The fix results in the socket being closed and not attempting to read the next request when an error occurs. If a content-length is provided then the network error can be detected by the remote peer, otherwise a truncated body is returned to the client.