Skip to content

Commit 6f0b9fc

Browse files
committed
Use Python Requests built-in method methods where possible
1 parent 28260f9 commit 6f0b9fc

File tree

17 files changed

+30
-17
lines changed

17 files changed

+30
-17
lines changed

src/targets/python/requests.js

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,16 @@ const util = require('util')
1414
const CodeBuilder = require('../../helpers/code-builder')
1515
const helpers = require('./helpers')
1616

17+
const builtInMethods = [
18+
'HEAD',
19+
'GET',
20+
'POST',
21+
'PUT',
22+
'PATCH',
23+
'DELETE',
24+
'OPTIONS'
25+
]
26+
1727
module.exports = function (source, options) {
1828
const opts = Object.assign({
1929
indent: ' ',
@@ -89,7 +99,10 @@ module.exports = function (source, options) {
8999

90100
// Construct request
91101
const method = source.method
92-
let request = util.format('response = requests.request("%s", url', method)
102+
103+
let request = builtInMethods.includes(method)
104+
? util.format('response = requests.%s(url', method.toLowerCase())
105+
: util.format('response = requests.request("%s", url', method)
93106

94107
if (hasPayload) {
95108
if (jsonPayload) {

test/fixtures/output/python/requests/application-form-encoded.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55
payload = "foo=bar&hello=world"
66
headers = { "content-type": "application/x-www-form-urlencoded" }
77

8-
response = requests.request("POST", url, data=payload, headers=headers)
8+
response = requests.post(url, data=payload, headers=headers)
99

1010
print(response.text)

test/fixtures/output/python/requests/application-json.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,6 @@
1212
}
1313
headers = { "content-type": "application/json" }
1414

15-
response = requests.request("POST", url, json=payload, headers=headers)
15+
response = requests.post(url, json=payload, headers=headers)
1616

1717
print(response.text)

test/fixtures/output/python/requests/cookies.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,6 @@
44

55
headers = { "cookie": "foo=bar; bar=baz" }
66

7-
response = requests.request("POST", url, headers=headers)
7+
response = requests.post(url, headers=headers)
88

99
print(response.text)

test/fixtures/output/python/requests/full.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@
1515
"content-type": "application/x-www-form-urlencoded"
1616
}
1717

18-
response = requests.request("POST", url, data=payload, headers=headers, params=querystring)
18+
response = requests.post(url, data=payload, headers=headers, params=querystring)
1919

2020
print(response.text)

test/fixtures/output/python/requests/headers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,6 @@
77
"x-foo": "Bar"
88
}
99

10-
response = requests.request("GET", url, headers=headers)
10+
response = requests.get(url, headers=headers)
1111

1212
print(response.text)

test/fixtures/output/python/requests/https.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@
22

33
url = "https://mockbin.com/har"
44

5-
response = requests.request("GET", url)
5+
response = requests.get(url)
66

77
print(response.text)

test/fixtures/output/python/requests/jsonObj-multiline.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55
payload = { "foo": "bar" }
66
headers = { "content-type": "application/json" }
77

8-
response = requests.request("POST", url, json=payload, headers=headers)
8+
response = requests.post(url, json=payload, headers=headers)
99

1010
print(response.text)

test/fixtures/output/python/requests/jsonObj-null-value.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55
payload = { "foo": None }
66
headers = { "content-type": "application/json" }
77

8-
response = requests.request("POST", url, json=payload, headers=headers)
8+
response = requests.post(url, json=payload, headers=headers)
99

1010
print(response.text)

test/fixtures/output/python/requests/multipart-data.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55
payload = "-----011000010111000001101001\r\nContent-Disposition: form-data; name=\"foo\"; filename=\"hello.txt\"\r\nContent-Type: text/plain\r\n\r\nHello World\r\n-----011000010111000001101001--\r\n"
66
headers = { "content-type": "multipart/form-data; boundary=---011000010111000001101001" }
77

8-
response = requests.request("POST", url, data=payload, headers=headers)
8+
response = requests.post(url, data=payload, headers=headers)
99

1010
print(response.text)

0 commit comments

Comments
 (0)