fix(curl) remove boundary form content-type header (#227)

Author: nateslo

src/targets/shell/curl.js

@@ -12,6 +12,7 @@
 
 const util = require('util')
 const helpers = require('../../helpers/shell')
+const headerHelpers = require('../../helpers/headers')
 const CodeBuilder = require('../../helpers/code-builder')
 
 module.exports = function (source, options) {
@@ -39,6 +40,22 @@ module.exports = function (source, options) {
     code.push(opts.short ? '-0' : '--http1.0')
   }
 
+  // if multipart form data, we want to remove the boundary
+  if (source.postData.mimeType === 'multipart/form-data') {
+    const contentTypeHeaderName = headerHelpers.getHeaderName(source.headersObj, 'content-type')
+    const contentTypeHeader = source.headersObj[contentTypeHeaderName]
+
+    if (contentTypeHeaderName && contentTypeHeader) {
+      // remove the leading semi colon and boundary
+      // up to the next semi colon or the end of string
+      const noBoundary = contentTypeHeader.replace(/; boundary.+?(?=(;|$))/, '')
+
+      // replace the content-type header with no boundary in both headersObj and allHeaders
+      source.headersObj[contentTypeHeaderName] = noBoundary
+      source.allHeaders[contentTypeHeaderName] = noBoundary
+    }
+  }
+
   // construct headers
   Object.keys(source.headersObj).sort().forEach(function (key) {
     const header = util.format('%s: %s', key, source.headersObj[key])

test/fixtures/output/shell/curl/multipart-data.sh

@@ -1,4 +1,4 @@
 curl --request POST \
   --url http://mockbin.com/har \
-  --header 'content-type: multipart/form-data; boundary=---011000010111000001101001' \
+  --header 'content-type: multipart/form-data' \
   --form [email protected]

test/fixtures/output/shell/curl/multipart-file.sh

@@ -1,4 +1,4 @@
 curl --request POST \
   --url http://mockbin.com/har \
-  --header 'content-type: multipart/form-data; boundary=---011000010111000001101001' \
+  --header 'content-type: multipart/form-data' \
   --form foo=@test/fixtures/files/hello.txt

test/fixtures/output/shell/curl/multipart-form-data.sh

@@ -1,4 +1,4 @@
 curl --request POST \
   --url http://mockbin.com/har \
-  --header 'Content-Type: multipart/form-data; boundary=---011000010111000001101001' \
+  --header 'Content-Type: multipart/form-data' \
   --form foo=bar