Skip to content

Commit 3f7a24d

Browse files
committed
Enable updated Mac notarization
1 parent e85e6e1 commit 3f7a24d

File tree

5 files changed

+26
-178
lines changed

5 files changed

+26
-178
lines changed

.github/workflows/ci.yml

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,23 @@ jobs:
3030

3131
- run: npm ci
3232

33+
# The API key in APPLE_API_KEY is a PEM cert that must be read from disk:
34+
- run: echo "$APPLE_API_KEY" > ./apple-api-key.p8
35+
if: matrix.os == 'macos-11'
36+
env:
37+
APPLE_API_KEY: ${{ secrets.APPLE_API_KEY }}
38+
3339
- run: npm run build
3440
env:
3541
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
36-
APPLE_ID: ${{ secrets.APPLE_ID }}
37-
APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }}
42+
# For Mac notarization:
43+
APPLE_API_ISSUER: ${{ secrets.APPLE_API_ISSUER }}
44+
APPLE_API_KEY_ID: ${{ secrets.APPLE_API_KEY_ID }}
45+
APPLE_API_KEY: ./apple-api-key.p8
46+
# For Mac signing:
3847
CSC_LINK: ${{ secrets.CSC_LINK }}
3948
CSC_KEY_PASSWORD: ${{ secrets.CSC_KEY_PASSWORD }}
49+
# For Windows signing:
4050
WIN_CSC_LINK: ${{ secrets.WIN_CSC_LINK }}
4151
WIN_CSC_KEY_PASSWORD: ${{ secrets.WIN_CSC_KEY_PASSWORD }}
4252

package-lock.json

Lines changed: 12 additions & 140 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@
6161
"icon": "src/icons/icon.icns",
6262
"entitlements": "src/entitlements.plist",
6363
"entitlementsInherit": "src/entitlements.plist",
64-
"forceCodeSigning": false,
65-
"notarize": false
64+
"forceCodeSigning": true,
65+
"notarize": true
6666
},
6767
"dmg": {
6868
"artifactName": "HttpToolkit-${version}.dmg"
@@ -119,7 +119,6 @@
119119
"appImage": {
120120
"artifactName": "HttpToolkit-${version}.AppImage"
121121
},
122-
"afterSign": "./src/hooks/after-sign.js",
123122
"publish": null
124123
},
125124
"dependencies": {
@@ -148,7 +147,6 @@
148147
"cross-env": "^7.0.3",
149148
"electron": "^22.3.26",
150149
"electron-builder": "^24.13.3",
151-
"electron-notarize": "^1.0.0",
152150
"lodash": "^4.17.21",
153151
"node-fetch": "^2.6.7",
154152
"targz": "^1.0.1",

src/hooks/after-sign.js

Lines changed: 0 additions & 2 deletions
This file was deleted.

src/notarize.ts

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)