Skip to content

Commit 6573e1b

Browse files
committed
Update release binary names and include ${arch} wherever relevant
Bit more awkward to implement than I'd like, since it seems that .zip can't be a target in itself seemingly.
1 parent eed8d98 commit 6573e1b

File tree

2 files changed

+8
-10
lines changed

2 files changed

+8
-10
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ jobs:
112112
- name: Submit package using wingetcreate
113113
run: |
114114
$packageVersion = "${{ github.ref }}" -replace 'refs/tags/v', ''
115-
$installerUrl = "https://github.com/httptoolkit/httptoolkit-desktop/releases/download/v$packageVersion/HttpToolkit-installer-$packageVersion.exe"
115+
$installerUrl = "https://github.com/httptoolkit/httptoolkit-desktop/releases/download/v$packageVersion/HttpToolkit-$packageVersion.exe"
116116
117117
# Update package using wingetcreate
118118
Invoke-WebRequest https://aka.ms/wingetcreate/latest -OutFile wingetcreate.exe

package.json

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
"extraResources": [
5454
"httptoolkit-server/**/*"
5555
],
56+
"artifactName": "HttpToolkit-${version}-${arch}.${ext}",
5657
"mac": {
5758
"target": [
5859
"dmg"
@@ -64,21 +65,18 @@
6465
"forceCodeSigning": true,
6566
"notarize": true
6667
},
67-
"dmg": {
68-
"artifactName": "HttpToolkit-${version}.dmg"
69-
},
7068
"win": {
7169
"target": [
7270
"nsis",
7371
"zip"
7472
],
75-
"artifactName": "HttpToolkit-${os}-${arch}-${version}.${ext}",
73+
"artifactName": "HttpToolkit-${version}-${os}-${arch}.${ext}",
7674
"icon": "./src/icons/icon.ico",
7775
"forceCodeSigning": true
7876
},
7977
"nsis": {
8078
"installerIcon": "./src/icons/icon.ico",
81-
"artifactName": "HttpToolkit-installer-${version}.exe",
79+
"artifactName": "HttpToolkit-${version}.exe",
8280
"deleteAppDataOnUninstall": true
8381
},
8482
"linux": {
@@ -88,8 +86,8 @@
8886
"AppImage",
8987
"zip"
9088
],
89+
"artifactName": "HttpToolkit-${version}-${os}-${arch}.${ext}",
9190
"executableName": "httptoolkit",
92-
"artifactName": "HttpToolkit-${os}-${arch}-${version}.${ext}",
9391
"category": "Development",
9492
"icon": "./src/icons/icon.svg",
9593
"maintainer": "[email protected]",
@@ -103,7 +101,7 @@
103101
}
104102
},
105103
"deb": {
106-
"artifactName": "HttpToolkit-${version}.deb",
104+
"artifactName": "HttpToolkit-${version}-${arch}.${ext}",
107105
"depends": [
108106
"libgtk-3-0",
109107
"libnotify4",
@@ -117,11 +115,11 @@
117115
]
118116
},
119117
"rpm": {
120-
"artifactName": "HttpToolkit-${version}.rpm",
118+
"artifactName": "HttpToolkit-${version}-${arch}.${ext}",
121119
"afterRemove": "scripts/post-uninstall-rpm.sh"
122120
},
123121
"appImage": {
124-
"artifactName": "HttpToolkit-${version}.AppImage"
122+
"artifactName": "HttpToolkit-${version}-${arch}.${ext}"
125123
},
126124
"publish": null
127125
},

0 commit comments

Comments
 (0)