Skip to content

Commit 83880bc

Browse files
committed
Don't report errors about shutdown process
These happen frequently, because the server shuts down and this creates various connection issues unexpectedly due to races there. We don't care about this, or anything else really - if it fails, we'll hard kill in a moment anyway.
1 parent 01e0ddb commit 83880bc

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/stop-server.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import * as ChildProcess from 'child_process';
22
import * as http from 'http';
33

4-
import { logError } from './errors';
54
import { delay } from './util';
65

76
const isRunning = (pid: number) => {
@@ -16,7 +15,7 @@ const isRunning = (pid: number) => {
1615

1716
export async function stopServer(proc: ChildProcess.ChildProcess, token: string) {
1817
await softShutdown(token)
19-
.catch(logError); // If that fails, continue shutting down anyway
18+
.catch(console.log); // If that fails, continue shutting down anyway
2019

2120
// In each case, that triggers a clean shutdown. We want to make sure it definitely shuts
2221
// down though, so we poll the process state, and kill it if it's still running in 3 seconds.

0 commit comments

Comments
 (0)