Skip to content

Commit 9f15e3a

Browse files
committed
Include timestamps in Windows code signatures
This is good practice, and notably ensures that installers will remain valid even after the certificate expires.
1 parent 8ebabea commit 9f15e3a

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

electron-forge.config.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
we have to do this instead.
1111
*/
1212

13+
const path = require('path');
1314
const {
1415
ELECTRON_FORGE_ELECTRON_WINSTALLER_CONFIG_CERTIFICATE_PASSWORD
1516
} = process.env;
@@ -54,8 +55,11 @@ module.exports = {
5455
"iconUrl": "https://httptoolkit.tech/favicon.ico",
5556
"setupIcon": "./src/icon.ico",
5657
"loadingGif": "./src/installing.gif",
57-
"certificateFile": "./certificates/encrypted-win-cert.pfx",
58-
"certificatePassword": ELECTRON_FORGE_ELECTRON_WINSTALLER_CONFIG_CERTIFICATE_PASSWORD
58+
"signWithParams": `/a /f "${
59+
path.resolve('./certificates/encrypted-win-cert.pfx')
60+
}" /p "${
61+
ELECTRON_FORGE_ELECTRON_WINSTALLER_CONFIG_CERTIFICATE_PASSWORD
62+
}" /tr http://timestamp.digicert.com/`
5963
},
6064
"electronInstallerDMG": {
6165
"name": "HTTP Toolkit",

0 commit comments

Comments
 (0)