Add a PR check workflow

Author: pimterry

.github/workflows/ci.yml

@@ -50,6 +50,7 @@ jobs:
 
       - run: npm run build
         env:
+          ENABLE_SIGNING: true
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           # For Mac notarization:
           APPLE_API_ISSUER: ${{ secrets.APPLE_API_ISSUER }}

.github/workflows/pr-check.yml

@@ -0,0 +1,59 @@
+# PR check workflow - should be equilvalent to the build step of the CI workflow, but
+# with signing disabled (and obviously no publishing etc either).
+
+name: PR Check
+on:
+  - pull_request
+  - push
+jobs:
+  build:
+    name: Build & test (unsigned)
+    strategy:
+      matrix:
+        include:
+          - platform: linux
+            arch: x64
+            os: "ubuntu-22.04"
+          - platform: linux
+            arch: arm64
+            os: "ubuntu-24.04-arm"
+          - platform: windows
+            arch: x64
+            os: "windows-2022"
+          - platform: mac
+            arch: x64
+            os: "macos-13"
+          - platform: mac
+            arch: arm64
+            os: "macos-14"
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 22.20.0
+          check-latest: true
+          cache: 'npm'
+
+      - name: Install system FPM to fix ARM64 Linux builds
+        if: matrix.platform == 'linux' && matrix.arch == 'arm64'
+        run: |
+          sudo apt-get update
+          sudo apt-get install ruby ruby-dev build-essential
+          sudo gem install --no-document fpm
+
+      - run: npm ci
+
+      - run: npm run build
+        env:
+          # Build dev builds only
+          ENABLE_SIGNING: false
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          USE_SYSTEM_FPM: ${{ matrix.platform == 'linux' && matrix.arch == 'arm64' }}
+
+      - uses: actions/upload-artifact@v4
+        with:
+          name: ${{ matrix.platform }}-${{ matrix.arch }}-distributables
+          path: dist/HttpToolkit-*
+          if-no-files-found: error

electron-builder.config.js

@@ -0,0 +1,35 @@
+// This config just re-exposes the config from package.json, but
+// disables code signing & notarization for PR builds where it won't work.
+
+const packageJson = require('./package.json');
+
+const unsignedMode = process.env.ENABLE_SIGNING !== 'true';
+
+const config = packageJson.build;
+
+if (unsignedMode) {
+  console.log('\nBuilding in UNSIGNED mode\n');
+
+  // Make it abundantly clear in the output that the builds aren't signed, so
+  // we don't accidentally distribute them. Different app & file names throughout.
+  config.productName = packageJson.name + ' - dev build';
+  config.extraMetadata.name += '-dev';
+  config.extraMetadata.productName += '-dev';
+
+  config.artifactName = config.artifactName.replace('${ext}', 'dev.${ext}');
+  for (let field in config) {
+    if (config[field]?.artifactName) {
+      config[field].artifactName =
+        config[field].artifactName.replace('${ext}', 'dev.${ext}');
+    }
+  }
+
+  config.mac.forceCodeSigning = false;
+  config.mac.notarize = false;
+  config.win.forceCodeSigning = false;
+  process.env.CSC_IDENTITY_AUTO_DISCOVERY = 'false';
+} else {
+  console.log('\nBuilding in SIGNED mode\n');
+}
+
+module.exports = config;

package.json

@@ -12,7 +12,7 @@
     "build": "npm run build:src && npm run build:electron",
     "build:src": "tsc",
     "postbuild:src": "tsx ./strip-preload-map.ts",
-    "build:electron": "npm run server:setup && electron-builder build",
+    "build:electron": "npm run server:setup && electron-builder build --config electron-builder.config.js",
     "build:dir-only": "npm run server:setup && electron-builder --dir",
     "start": "npm run server:setup && npm run start:app",
     "start:dev": "tsx ./skip-server.ts && cross-env HTK_DEV=true APP_URL='http://localhost:8080' npm run start:app",
@@ -77,7 +77,7 @@
     },
     "nsis": {
       "installerIcon": "./src/icons/icon.ico",
-      "artifactName": "HttpToolkit-${version}.exe",
+      "artifactName": "HttpToolkit-${version}.${ext}",
       "deleteAppDataOnUninstall": true,
       "oneClick": false,
       "allowToChangeInstallationDirectory": true,