Skip to content

Commit 2747cb9

Browse files
committed
Simplify DNS code by removing useless if()
getHostAddresses always returns a Set, even if empty, so this if was always true.
1 parent 9aaa3a0 commit 2747cb9

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

src/dns-server.ts

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -62,17 +62,15 @@ class DnsServer extends dns2.UDPServer {
6262
console.log(`Multiple hosts in internal DNS for hostname ${question.name}:`, answers);
6363
}
6464

65-
if (answers) {
66-
answers.forEach((answer) => {
67-
response.answers.push({
68-
name: question.name,
69-
type: dns2.Packet.TYPE.A,
70-
class: dns2.Packet.CLASS.IN,
71-
ttl: 0,
72-
address: answer
73-
});
65+
answers.forEach((answer) => {
66+
response.answers.push({
67+
name: question.name,
68+
type: dns2.Packet.TYPE.A,
69+
class: dns2.Packet.CLASS.IN,
70+
ttl: 0,
71+
address: answer
7472
});
75-
}
73+
});
7674

7775
sendResponse(response);
7876
}

0 commit comments

Comments
 (0)